Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authentication): issues/373 use platform not authorized #402

Merged

Conversation

zanewoodfin
Copy link
Contributor

What's included

  • feat(authentication): issues/373 use platform not authorized

How to test

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. attempt to visit any page while not authorized or change line 65 of authentication.js to if (false) { and try to visit any page

Example

unauthorized

Updates issue/story

Updates #373

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2020

Codecov Report

Merging #402 into ci will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #402   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files          69       69           
  Lines        1693     1693           
  Branches      388      388           
=======================================
  Hits         1566     1566           
  Misses        111      111           
  Partials       16       16           
Impacted Files Coverage Δ
src/components/authentication/authentication.js 60.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07cccd6...ce1a8d7. Read the comment docs.

Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants