Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rhosak,rhacs): ent-5129 (sw-47) billing provider for subscriptions inventory #947

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jun 21, 2022

What's included

  • refactor(inventoryCardSubscriptions): ent-5129 camel to snake
    • config, products updated to use snake case
    • services, constants updated with subscriptions types
  • fix(rhosak,rhacs): ent-5129 billing provider for subscriptions inventory
    • config, rhosak, rhacs billing provider column
    • services, subscriptions mock

Notes

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. login and
  5. confirm all subscriptions table inventory column headers for RHEL, OpenShift console, and RHOSAK are display correctly, and
  6. confirm the billing provider column is available for subscriptions inventory in RHOSAK

Example

Activated billing provider column

Notes regarding what copy displays when, #936
Screen Shot 2022-06-21 at 4 36 12 PM

Updates issue/story

ent-5129 aka SWATCH-47

@cdcabrera cdcabrera added bug Something isn't working 202208 project phase labels Jun 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #947 (fbd2ca5) into ci (3ef53f5) will decrease coverage by 0.13%.
The diff coverage is 70.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #947      +/-   ##
==========================================
- Coverage   94.05%   93.91%   -0.14%     
==========================================
  Files         129      129              
  Lines        4020     4027       +7     
  Branches     1571     1578       +7     
==========================================
+ Hits         3781     3782       +1     
- Misses        221      227       +6     
  Partials       18       18              
Impacted Files Coverage Δ
src/config/product.satellite.js 88.57% <ø> (ø)
src/services/rhsm/rhsmServices.js 100.00% <ø> (ø)
src/types/rhsmApiTypes.js 100.00% <ø> (ø)
src/config/product.openshiftContainer.js 82.50% <66.66%> (-4.68%) ⬇️
src/config/product.rhel.js 84.09% <66.66%> (-4.29%) ⬇️
src/config/product.rhosak.js 83.72% <66.66%> (-3.46%) ⬇️
src/services/rhsm/rhsmConstants.js 100.00% <100.00%> (ø)
src/services/rhsm/rhsmSchemas.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ef53f5...fbd2ca5. Read the comment docs.

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 22, 2022
…Insights#947)

* config, products updated to use snake case
* services, constants updated with subscriptions types
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 22, 2022
…ghts#947)

* config, rhosak billing provider column
* services, subscriptions mock
@cdcabrera
Copy link
Member Author

cdcabrera commented Jun 24, 2022

As of 20220623 going to separate the refactor work for casing into a separate PR, see #949

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 24, 2022
…Insights#947)

* config, products updated to use snake case
* services, constants updated with subscriptions types
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 24, 2022
…ghts#947)

* config, rhosak billing provider column
* services, subscriptions mock
@cdcabrera cdcabrera added the blocked Prevented from continuing label Jun 24, 2022
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jun 24, 2022
…Insights#947)

* config, products updated to use snake case
* services, constants updated with subscriptions types
@cdcabrera cdcabrera changed the title fix(rhosak): ent-5129 billing provider for subscriptions inventory fix(rhosak): ent-5129 (sw-47) billing provider for subscriptions inventory Jul 27, 2022
@cdcabrera cdcabrera removed the blocked Prevented from continuing label Aug 31, 2022
@cdcabrera
Copy link
Member Author

As of 20220831 the API work has merged to the stage environment, removing the unblocked label.

@cdcabrera cdcabrera force-pushed the ent-5129 branch 2 times, most recently from d975f07 to f77913f Compare August 31, 2022 15:59
@cdcabrera cdcabrera changed the title fix(rhosak): ent-5129 (sw-47) billing provider for subscriptions inventory fix(rhosak,rhacs): ent-5129 (sw-47) billing provider for subscriptions inventory Aug 31, 2022
* config, rhosak, rhacs billing provider column
* services, subscriptions mock
@cdcabrera cdcabrera merged commit 7c7feef into RedHatInsights:dev Aug 31, 2022
cdcabrera added a commit that referenced this pull request Sep 1, 2022
* config, rhosak, rhacs billing provider column
* services, subscriptions mock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202208 project phase bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants