Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(inventoryCardSubscriptions): ent-5129 camel to snake #949

Merged
merged 3 commits into from
Jun 24, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jun 24, 2022

What's included

  • refactor(inventoryCardSubscriptions): ent-5129 camel to snake
    • config, products updated to use snake case
    • services, constants updated with subscriptions types

Notes

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. login and
  5. confirm all subscriptions table inventory column headers for RHEL, OpenShift console, and RHOSAK are displaying correctly

Example

...

Updates issue/story

ent-5129

* config, products updated to use snake case
* services, constants updated with subscriptions types
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #949 (940dae2) into ci (7776fd7) will decrease coverage by 0.11%.
The diff coverage is 68.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #949      +/-   ##
==========================================
- Coverage   94.06%   93.94%   -0.12%     
==========================================
  Files         129      129              
  Lines        4025     4030       +5     
  Branches     1572     1578       +6     
==========================================
  Hits         3786     3786              
- Misses        221      226       +5     
  Partials       18       18              
Impacted Files Coverage Δ
src/config/product.satellite.js 88.57% <ø> (ø)
src/types/rhsmApiTypes.js 100.00% <ø> (ø)
src/config/product.rhosak.js 82.92% <57.14%> (-4.26%) ⬇️
src/config/product.openshiftContainer.js 82.50% <66.66%> (-4.68%) ⬇️
src/config/product.rhel.js 84.09% <66.66%> (-4.29%) ⬇️
src/services/rhsm/rhsmConstants.js 100.00% <100.00%> (ø)
src/services/rhsm/rhsmSchemas.js 100.00% <100.00%> (ø)
src/common/helpers.js 100.00% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7776fd7...940dae2. Read the comment docs.

@cdcabrera cdcabrera merged commit 4836484 into RedHatInsights:ci Jun 24, 2022
cdcabrera added a commit that referenced this pull request Jun 24, 2022
* config, products updated to use snake case
* services, constants updated with subscriptions types
cdcabrera added a commit that referenced this pull request Jun 24, 2022
* config, products updated to use snake case
* services, constants updated with subscriptions types
cdcabrera added a commit that referenced this pull request Jun 24, 2022
* config, products updated to use snake case
* services, constants updated with subscriptions types
cdcabrera added a commit that referenced this pull request Jul 11, 2022
* config, products updated to use snake case
* services, constants updated with subscriptions types
cdcabrera added a commit that referenced this pull request Jul 11, 2022
* config, products updated to use snake case
* services, constants updated with subscriptions types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202208 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants