Issue #666: add a log message in case FileWrite fails

RotherOSS · Dec 19, 2020 · c695bc3 · c695bc3
1 parent 15f23fd
commit c695bc3
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/Kernel/System/Package.pm b/Kernel/System/Package.pm
@@ -4157,13 +4157,22 @@ sub _FileInstall {
     }
 
     # write file
-    return if !$MainObject->FileWrite(
+    my $FileWriteOk = $MainObject->FileWrite(
         Location   => $RealFile,
         Content    => \$Param{File}->{Content},
         Mode       => 'binmode',
         Permission => $Param{File}->{Permission},
     );
 
+    if ( ! $FileWriteOk ) {
+        $Kernel::OM->Get('Kernel::System::Log')->Log(
+            Priority => 'error',
+            Message  => "Sorry, can't install package because the file $RealFile can't be created.",
+        );
+
+        return;
+    }
+
     print STDERR "Notice: Install $RealFile ($Param{File}->{Permission})!\n";
 
     return 1;