-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files in Custom/Kernel are (initially) not loaded in docker installations. #666
Comments
Hi @svenoe , I will take a look at this. Obviously the modified checking is done by Gazelle, not by Nginx. |
Refreshing changed Perl modules is mainly a question what is checked how often. I investigated how it is currently done.
Apache2::Reload looks for every request whether the files referenced in %INC have changed
Check whether ZZZAAuto.pm has changed for every request. Check all other modules every 10s. Neither approach checks for whether a module with the same package name has been installed in a different location. (But it might have been solved in KIXCore) Several solutions are possible:
Regarding 1,: this is not user friendly. Regarding 2.: My favourite solution would be 2.. Not overriding core modules is best practice anyways. Regarding 4.: This is probably not appropriate for production Regarding 5.: places a burden on extension developers, which is a bad thing to do. I don't see much speaking against solution 3. . This would be fairly small change in Kernel::System::Package::_FileInstall(). Let's try this. |
As public methods are included in between the markers.
@svenoe I assigned this to you because I thing a second pair of eyes is useful here. |
…g_the_core Issue #666 dark forces touching the core
Works for me. :) (Just copied a file to Custom/Kernel/Modules and modified it.) |
After installing a package with a file in Custom/Kernel/[...] and then adding some debugging output to said file (print STDERR), the output is not shown (the modified file is not loaded), until I change the same file in Kernel/[...]. I'm not sure whether this problem is present for the file added by the package straight from installation, or whether it only affects my manual editing of it.
In any case, I guess nginx only checks for file changes in Kernel, or something like that. @bschmalhofer I'm assigning it to you, if you don't have time, you can give it back to me, but maybe you could give me a hint on where to look. :)
The text was updated successfully, but these errors were encountered: