Rating implementation #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fixed field called rating is implemented, accepting values from 1 to 10, or None if not set.
|
@pboettch it looks ok to me is this ready for merge? |
|
No, let me finish the work on tscat_gui with this change, to see whether it fits all the needs. In the best case, no more changes necessary here. |
jeandet
reviewed
Nov 15, 2023
tests/test_event.py
Outdated
| @@ -102,3 +102,30 @@ def test_constructor_with_dynamic_attribute_manual_access(self): | |||
| self.assertEqual(e.field_str, "string-test") | |||
| self.assertEqual(e.field_bool, True) | |||
| self.assertEqual(e.field_dt, dt_val) | |||
|
|
|||
| def test_event_rating(self): | |||
There was a problem hiding this comment.
Should be split in two data driven tests.
jeandet
reviewed
Nov 15, 2023
jeandet
reviewed
Nov 15, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1674 1770 +96
=========================================
+ Hits 1674 1770 +96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pboettch
force-pushed
the
rating-impl
branch
from
e766dad
to
66e9ba7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fixed field called rating is implemented, accepting values from 1 to 10, or None if not set.