chore(style): Make some common patterns more consistent #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffcarbs
force-pushed
the
chore/cleanup
branch
from
f6986ac
to
08530eb
Compare
Current coverage is 100% (diff: 100%)@@ master #614 diff @@
====================================
Files 119 119
Lines 1915 1913 -2
Methods 0 0
Messages 0 0
Branches 0 0
====================================
- Hits 1915 1913 -2
Misses 0 0
Partials 0 0
|
levithomason
requested changes
Oct 4, 2016
| @@ -10,10 +8,7 @@ import Image from '../../elements/Image' | |||
| * An item can contain an image | |||
| * */ | |||
There was a problem hiding this comment.
While we're at it, there are a number of doc blocks with * */ as a closing. This should just be */. The copy pasta there has been killing me a little :)
|
Also, there is technically a |
|
Github is back, the outage killed tests. I just retried them, we'll see. |
- Added className prop to MessageItem
- Swapped order of `className={classes} {...rest}` to `{...rest} className={classes}`
- Use ElementType in a few places we weren't
- Always import 'classnames' as 'cx'
- Always order setting variables: props, classes, rest, ElementType
- When returning early because children, render a one-liner
- Order children before className in props
- Fix closing docbock "* */" => "**/"
jeffcarbs
force-pushed
the
chore/cleanup
branch
from
68e2caa
to
0adcc47
Compare
|
Was missing an import. Fixed and pushed up. |
|
Ready to go here then? |
levithomason
approved these changes
Oct 4, 2016
|
Going! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some things that we did in a lot of files but slightly differently. These aren't really lintable so there's no way to enforce them moving forward, but figured I take a pass through so at least it's more likely someone will copy/paste the "right" way 😄 . I tried to grep for some of this stuff when possible and chose the most common variation of the pattern:
MessageItemclassName={classes} {...rest}to{...rest} className={classes}(the latter was way more common and makes more sense).ElementTypein a few places we weren't.<ElementType>