Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(style): Make some common patterns more consistent #614

Merged
merged 1 commit into from
Oct 4, 2016
Merged

chore(style): Make some common patterns more consistent #614

merged 1 commit into from
Oct 4, 2016

Commits on Oct 4, 2016

  1. style(all): Make some common patterns more consistent 

    - Added className prop to MessageItem
- Swapped order of `className={classes} {...rest}` to `{...rest} className={classes}`
- Use ElementType in a few places we weren't
- Always import 'classnames' as 'cx'
- Always order setting variables: props, classes, rest, ElementType
- When returning early because children, render a one-liner
- Order children before className in props
- Fix closing docbock "* */" => "**/"
    @jeffcarbs
    jeffcarbs committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    0adcc47 View commit details
    Browse the repository at this point in the history