BREAKING CHANGE: update Confirm to Modal v1 API #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
changed the title
|
Feels like this should've been caught with a test. Can you add just a basic "pass open, confirm is visible on page" test, similar to the |
|
Absolutely agreed, on my list. IMO no public API ought to be untested. |
Current coverage is 100% (diff: 100%)@@ master #634 diff @@
====================================
Files 119 119
Lines 1890 1892 +2
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 1890 1892 +2
Misses 0 0
Partials 0 0
|
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Confirm addon to use the Modal v1 API. It is currently broken.
active=>openonHide=>onClose