Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Confirm): switch from active prop to open #648

Closed
wants to merge 1 commit into from
Closed

feat(Confirm): switch from active prop to open #648

wants to merge 1 commit into from

Conversation

typehorror
Copy link
Contributor

@typehorror typehorror commented Oct 8, 2016 •
edited
Loading

  • Switch from Confirm.props.active to Confirm.props.open
  • Use createShorthandFactory on Modal shorthands
  • Use the shortHand create method for Confirm content
  • Use children as modal content or props shorthands

@levithomason
Copy link
Member

This work is ongoing in #634

@levithomason
Copy link
Member

Sorry, just saw your comment on #647 about making this. Had I seen it early, I would've pointed you to the work in #634 to avoid the duplicate!

@typehorror
Copy link
Contributor Author

No worries, that's what I guessed 👍

@levithomason
Copy link
Member

Fixed in semantic-ui-react@0.55.0

@typehorror typehorror deleted the fix/confirm-open branch October 10, 2016 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@typehorror @levithomason