S3655: Fields with methods, local functions, yield and async #6981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonioaversa
changed the title
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-3
branch
from
2d46646
to
d20bcf2
Compare
antonioaversa
changed the title
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-3
branch
from
d20bcf2
to
50d2b5e
Compare
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-2
branch
from
f7893e0
to
08ef95f
Compare
Tim-Pohlmann
requested changes
Mar 24, 2023
|
|
||
| theField = null; | ||
| _ = theField.Value; // Noncompliant, empty | ||
| _ = theField.Value; // Compliant, when reached the ".Value" above implies aField is not null |
There was a problem hiding this comment.
Suggested change
| _ = theField.Value; // Compliant, when reached the ".Value" above implies aField is not null | |
| _ = theField.Value; // Compliant, when reached the ".Value" above implies theField is not null |
Comment on lines
767
to
850
| async Task WithAsyncAwait() | ||
| { | ||
| _ = theField.Value; // Compliant, unknown | ||
| await AnAsyncOperation(); | ||
|
|
||
| theField = null; | ||
| await AnAsyncOperation(); | ||
| _ = theField.Value; // Compliant, unknown | ||
|
|
||
| theField = 42; | ||
| await AnAsyncOperation(); | ||
| _ = theField.Value; // Compliant, unknown | ||
|
|
||
| theField = null; | ||
| await AnotherAsyncOperation(theField.Value); // Noncompliant, empty | ||
| _ = theField.Value; // Compliant, unknown | ||
|
|
||
| theField = null; | ||
| await AnAsyncOperation(); | ||
| _ = theField.Value; // Compliant, yield break above stops execution | ||
|
|
||
| async Task<int> AnAsyncOperation() => await Task.FromResult(42); | ||
| async Task<int> AnotherAsyncOperation(int i) => await Task.FromResult(42); | ||
| } |
There was a problem hiding this comment.
Add tests where the task is created before the the assignment:
var task = AnAsyncOperation();
theField = null;
await task;
_ = theField.Value;
08ef95f
to
56b4f16
Compare
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-3
branch
from
50d2b5e
to
29ba312
Compare
Tim-Pohlmann
approved these changes
Mar 27, 2023
pavel-mikula-sonarsource
approved these changes
Mar 27, 2023
|
|
||
| theField = null; | ||
| yield break; | ||
| _ = theField.Value; // Compliant, yield break above stops execution |
There was a problem hiding this comment.
Here you can use "unreachable" 😄
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-2
branch
from
56b4f16
to
84bf1c2
Compare
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-3
branch
from
e41d4ac
to
0d1fa32
Compare
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-2
branch
from
84bf1c2
to
9b2a752
Compare
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-3
branch
from
0d1fa32
to
158e2a7
Compare
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-2
branch
from
9b2a752
to
37dd64c
Compare
Base automatically changed from
Antonio/S3655-cs9-cs10-syntax-step6-2
to
feature/SE
March 28, 2023 14:45
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-3
branch
from
1f63918
to
ae2baec
Compare
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-3
branch
from
ae2baec
to
e1f168f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
pavel-mikula-sonarsource
pushed a commit
that referenced
this pull request
Mar 31, 2023
pavel-mikula-sonarsource
pushed a commit
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 3 of task 6 of #6794
Previous task: #6967