🐛 Use custom file tree walker instead of globby

packages/core/package.json

@@ -19,7 +19,6 @@
     "chokidar": "^3.5.2",
     "decompress": "^4.2.1",
     "follow-redirects": "^1.14.8",
-    "globby": "^11.0.4",
     "ignore": "^5.3.1",
     "pako": "^2.0.4",
     "rfdc": "^1.3.0",

packages/core/src/common/externals/BrowserExternals.ts

@@ -104,9 +104,6 @@ class BrowserFileSystem implements ExternalFileSystem {
 	async chmod(_location: FsLocation, _mode: number): Promise<void> {
 		return
 	}
-	async getAllFiles(_location: FsLocation): Promise<string[]> {
-		return []
-	}
 	async mkdir(
 		location: FsLocation,
 		_options?: { mode?: number | undefined; recursive?: boolean | undefined } | undefined,
@@ -118,6 +115,10 @@ class BrowserFileSystem implements ExternalFileSystem {
 		this.states[location] = { type: 'directory' }
 		this.saveStates()
 	}
+	async readdir(_location: FsLocation) {
+		// Not implemented
+		return []
+	}
 	async readFile(location: FsLocation): Promise<Uint8Array> {
 		location = location.toString()
 		const entry = this.states[location]

packages/core/src/common/externals/NodeJsExternals.ts

@@ -2,7 +2,6 @@
 import chokidar from 'chokidar'
 import decompress from 'decompress'
 import followRedirects from 'follow-redirects'
-import globby from 'globby'
 import { Buffer } from 'node:buffer'
 import cp from 'node:child_process'
 import crypto from 'node:crypto'
@@ -84,14 +83,12 @@ export const NodeJsExternals: Externals = {
 		chmod(location, mode) {
 			return fsp.chmod(toFsPathLike(location), mode)
 		},
-		async getAllFiles(location, depth) {
-			const path = toPath(location).replaceAll('\\', '/') + '**/*'
-			const files = await globby(path, { absolute: true, dot: true, deep: depth })
-			return files.map(uriFromPath)
-		},
 		async mkdir(location, options) {
 			return void (await fsp.mkdir(toFsPathLike(location), options))
 		},
+		readdir(location) {
+			return fsp.readdir(toFsPathLike(location), { encoding: 'utf-8', withFileTypes: true })
+		},
 		readFile(location) {
 			return fsp.readFile(toFsPathLike(location))
 		},

packages/core/src/common/externals/index.ts

@@ -54,14 +54,15 @@ export interface ExternalFileSystem {
 	 * @param mode File mode bit mask (e.g. `0o775`).
 	 */
 	chmod(location: FsLocation, mode: number): Promise<void>
-	/**
-	 * @returns an array of file URIs under the given `location`.
-	 */
-	getAllFiles(location: FsLocation, depth?: number): Promise<string[]>
 	/**
 	 * @param options `mode` - File mode bit mask (e.g. `0o775`).
 	 */
 	mkdir(location: FsLocation, options?: { mode?: number; recursive?: boolean }): Promise<void>
+	readdir(
+		location: FsLocation,
+	): Promise<
+		{ name: string; isDirectory(): boolean; isFile(): boolean; isSymbolicLink(): boolean }[]
+	>
 	readFile(location: FsLocation): Promise<Uint8Array>
 	/**
 	 * Show the file/directory in the platform-specific explorer program.

packages/core/src/service/FileService.ts

@@ -220,7 +220,7 @@ export class FileUriSupporter implements UriProtocolSupporter {
 				if (fileUtil.isFileUri(uri) && (await externals.fs.stat(uri)).isDirectory()) {
 					uri = fileUtil.ensureEndingSlash(uri)
 					roots.push(uri as RootUriString)
-					files.set(uri, await externals.fs.getAllFiles(uri))
+					files.set(uri, await fileUtil.getAllFiles(externals, uri))
 				}
 			} catch (e) {
 				logger.error(`[FileUriSupporter#create] Bad dependency ${uri}`, e)