-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
I missed an overload case being an idiot - adding the missing source break for the case in #2071. ...also fixing KeyTouch ordering while in here. Note that adding `CommandFlags` back optional seems like a quick fix and I did try that route, but in a full test suite here it became apparent that created other ambiguous overload cases, so went this route.
- Loading branch information
1 parent
77a159c
commit c1aaf4f
Showing
11 changed files
with
108 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| using System; | ||
| using System.Threading.Tasks; | ||
| using Xunit; | ||
| using Xunit.Abstractions; | ||
|
|
||
| namespace StackExchange.Redis.Tests; | ||
|
|
||
| /// <summary> | ||
| /// This test set is for when we add an overload, to making sure all | ||
| /// past versions work correctly and aren't source breaking. | ||
| /// </summary> | ||
| [Collection(SharedConnectionFixture.Key)] | ||
| public class OverloadCompat : TestBase | ||
| { | ||
| public OverloadCompat(ITestOutputHelper output, SharedConnectionFixture fixture) : base (output, fixture) { } | ||
|
|
||
| [Fact] | ||
| public async Task StringGet() | ||
| { | ||
| using var conn = Create(); | ||
| var db = conn.GetDatabase(); | ||
| RedisKey key = Me(); | ||
| RedisValue val = "myval"; | ||
| var expiresIn = TimeSpan.FromSeconds(10); | ||
| var when = When.Always; | ||
| var flags = CommandFlags.None; | ||
|
|
||
| db.StringSet(key, val); | ||
| db.StringSet(key, val, expiry: expiresIn); | ||
| db.StringSet(key, val, when: when); | ||
| db.StringSet(key, val, flags: flags); | ||
| db.StringSet(key, val, expiry: expiresIn, when: when); | ||
| db.StringSet(key, val, expiry: expiresIn, when: when, flags: flags); | ||
| db.StringSet(key, val, expiry: expiresIn, when: when, flags: flags); | ||
|
|
||
| db.StringSet(key, val, expiresIn, When.NotExists); | ||
| db.StringSet(key, val, expiresIn, When.NotExists, flags); | ||
| db.StringSet(key, val, null); | ||
| db.StringSet(key, val, null, When.NotExists); | ||
| db.StringSet(key, val, null, When.NotExists, flags); | ||
|
|
||
| await db.StringSetAsync(key, val); | ||
| await db.StringSetAsync(key, val, expiry: expiresIn); | ||
| await db.StringSetAsync(key, val, when: when); | ||
| await db.StringSetAsync(key, val, flags: flags); | ||
| await db.StringSetAsync(key, val, expiry: expiresIn, when: when); | ||
| await db.StringSetAsync(key, val, expiry: expiresIn, when: when, flags: flags); | ||
| await db.StringSetAsync(key, val, expiry: expiresIn, when: when, flags: flags); | ||
|
|
||
| await db.StringSetAsync(key, val, expiresIn, When.NotExists); | ||
| await db.StringSetAsync(key, val, expiresIn, When.NotExists, flags); | ||
| await db.StringSetAsync(key, val, null); | ||
| await db.StringSetAsync(key, val, null, When.NotExists); | ||
| await db.StringSetAsync(key, val, null, When.NotExists, flags); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters