Fix for #2071: StringSet compatibility #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I missed an overload case being an idiot - adding the missing source break for the case in #2071. ...also fixing KeyTouch ordering while in here. Note that adding `CommandFlags` back optional seems like a quick fix and I did try that route, but in a full test suite here it became apparent that created other ambiguous overload cases, so went this route.
mgravell
reviewed
Apr 19, 2022
| @@ -2945,6 +2945,9 @@ public Task<long> StringLengthAsync(RedisKey key, CommandFlags flags = CommandFl | |||
| return ExecuteAsync(msg, ResultProcessor.Int64); | |||
| } | |||
|
|
|||
| // Backwards compatibility overloads: | |||
| public bool StringSet(RedisKey key, RedisValue value, TimeSpan? expiry, When when) => | |||
| StringSet(key, value, expiry, false, when, CommandFlags.None); | |||
There was a problem hiding this comment.
can't we just make flags on the overload below option with a default?
There was a problem hiding this comment.
Unfortunately I don't think so - the problem is then usage of RedisKey key, RedisValue value, TimeSpan? expiry, When when becomes ambiguous between the 2 methods. This was my first play based on your suggestion and my thoughts too, but couldn't make it work.
This does a few things globally to the interfaces: - De-dupes `<remarks>` since evidently past the first one doesn't count/render - Links our redis command links (and all others) so they're easily clickable! - Moves a few types to proper class files - In places sync/async methods are adjacent, utilizes `<inheritdoc cref="" /> to de-dupe - ...and some other misc URL cleanup throughout. In general: docs only change - I think we should merge this as-is to help PRs coming in, then I'll continue to iterate on docs.
|
Ah crap, reversed the ordering here and merged docs branch before this went to main, dammit. |
NickCraver
added a commit
that referenced
this pull request
Apr 19, 2022
|
@mgravell apologies for noise (I goofed on PR layering), here's the issue with the simple fix which I think we have to assume may be in use: If we can go simpler I'm all for it, just didn't see a way to account for current possible uses. |
mgravell
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed an overload case being an idiot - adding the missing source break for the case in #2071.
...also fixing KeyTouch ordering while in here.
Note that adding
CommandFlagsback optional seems like a quick fix and I did try that route, but in a full test suite here it became apparent that created other ambiguous overload cases, so went this route.