Handle looping music, Indicate song with seamless loops in docs, automatic pre-releases #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #411 +/- ##
===========================================
+ Coverage 81.38% 81.98% +0.60%
===========================================
Files 91 92 +1
Lines 3046 3148 +102
===========================================
+ Hits 2479 2581 +102
Misses 567 567
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ViMaSter
force-pushed
the
loopDemo
branch
2 times, most recently
from
4abefcd
to
dbb2085
Compare
|
If anyone wants to review it already:
Just need to hook the Script into the |
ViMaSter
force-pushed
the
loopDemo
branch
2 times, most recently
from
c2313ac
to
316404a
Compare
ViMaSter
force-pushed
the
loopDemo
branch
9 times, most recently
from
258ec85
to
a027af4
Compare
ViMaSter
changed the title
ViMaSter
force-pushed
the
loopDemo
branch
2 times, most recently
from
a029141
to
c3ddd8b
Compare
ViMaSter
commented
Sep 2, 2024
Comment on lines
+35
to
+40
| echo "version_number=$(date +'%Y.%m.%d')-$(echo $GITHUB_RUN_ID)" >> $GITHUB_OUTPUT | ||
| if [[ '${{ github.event.inputs.createRelease }}' == 'true' ]]; then | ||
| echo "version_name="Release v${{ needs.setVersionNumber.outputs.version_number }}" >> $GITHUB_OUTPUT | ||
| else | ||
| echo "version_name="Pre-release v${{ needs.setVersionNumber.outputs.version_number }}" >> $GITHUB_OUTPUT | ||
| fi |
There was a problem hiding this comment.
The previous automation would've required us to set the version in Unity; now we just use a timestamp + GitHub Actions's unique run ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT PR UNTIL DYNAMIC ASSET LOAD SOFTLOCK IS RESOLVED
Summary
developI'd recommend looking at the PR with these filters to focus on the important stuff:
Before/after screenshots and/or animated gif
Songs previously only looped from start to finish. Composers can now specify loop-information: intros, loop-sections and outros.
If a song provided by the composers contains loop information, it is highlighted in the documentation:
Also changes the GitHub Release behavior to automatically create pre-releases whenever a build succeeds on
develop.Testing instructions
Find a song with loop markers embedded into the
.oggfile. Play it and notice that the intro only is played once. Also a new GitHub pre-release should appear around 45 minutes after this is integrated intodevelop.Additional information
[ ]Changes UI[ ]Introduces new feature[ ]Removes existing feature[x]Has associated resource:developis updated #467