-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle looping music, Indicate song with seamless loops in docs, automatic pre-releases #411
Draft
ViMaSter
wants to merge
19
commits into
develop
Choose a base branch
from
loopDemo
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0f3c204
feat: Adds loopable music clip loader
ViMaSter a3d2e2f
feat: Adds support for .ogg files without loop markers
ViMaSter e5b98ef
docs(ActionDecoder): Rephrases documentation
ViMaSter b76fa7c
fix: Prefixes paths for linux
ViMaSter 57d38c7
chore(docs): Update auto-generated docs
invalid-email-address 9c38d59
chore: Changes from .mp3 to .ogg
ViMaSter 17e9937
feat: Adds indicators for songs with loop markers
ViMaSter 779b54e
chore: Replaced .mp3s with .oggs to satisfy new docs filter
ViMaSter 9f667c9
fix: Normalizes Dialogue Chirp volume
ViMaSter 7f89cbf
feat: Automatically create pre-releases on `develop` pushes
ViMaSter f9adb99
fix: Pull LFS files as part of docs generation
ViMaSter f0af6c9
fix: Escapes strings
ViMaSter 530beab
chore(docs): Update auto-generated docs
invalid-email-address 4d2be8c
fix: Loads songs with meta data
ViMaSter 80085ec
chore: Relocates music to StreamingAssets directory
ViMaSter d2e004c
fix: ObjectPreloader uses new path when loading music
ViMaSter c3ddd8b
fix: ActionDecoder uses new path to music
ViMaSter a9cebf4
fix: Removes logging
ViMaSter 8bc0c1e
fix: Resolves test issues
ViMaSter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
.../Assets/Resources/Audio/Music/Static.meta → unity-ggjj/Assets/Plugins/NVorbis.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Git LFS file not shown
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous automation would've required us to set the version in Unity; now we just use a timestamp + GitHub Actions's unique run ID.