✨ an option to only update buying price if an item is in stock

[idinium96]

• closes Better Pricing #284

• not implement: Safe guard should be added here: if buying price = selling price of other bot users (simple bp.tf check) then buying price - 0.11 ref = new buying price. But the selling price stays the same with the market (other bots).

• new options.json properties:

  • pricelist.partialPriceUpdate.enable (default is false)
  • pricelist.partialPriceUpdate.thresholdInSeconds (default is 604800 seconds or 7 days.)
  • sendAlert.partialPrice.onUpdate (default is true)
  • sendAlert.partialPrice.onSuccessUpdatePartialPriced (default is true)
  • sendAlert.partialPrice.onFailedUpdatePartialPriced (default is true)

How does this work?

• Previously, on start, the bot will get full pricelist from prices.tf/custom-autopricer and then loop through the bot pricelist and compare the time. If time in the bot pricelist is less than the time in prices.tf/custom-autopricer pricelist entry, the bot will update the buying and selling prices along with the time.

Code

tf2autobot/src/classes/Pricelist.ts

Lines 916 to 1021 in b2c6102

	if (match !== null && match.autoprice) {
	const oldPrice = {
	buy: new Currencies(match.buy),
	sell: new Currencies(match.sell)
	};
	let pricesChanged = false;
	const optPartialUpdate = opt.pricelist.partialPriceUpdate;
	const isInStock = this.bot.inventoryManager.getInventory.getAmount(match.sku, true) > 0;
	const isNotExceedThreshold = data.time - match.time < optPartialUpdate.thresholdInSeconds;
	const isNotExcluded = !['5021;6'].concat(optPartialUpdate.excludeSKU).includes(match.sku);
	if (
	optPartialUpdate.enable &&
	isInStock &&
	isNotExceedThreshold &&
	this.globalKeyPrices !== undefined &&
	isNotExcluded
	) {
	// if optPartialUpdate.enable is true and the item is currently in stock
	// and difference between latest time and time recorded in pricelist is less than threshold
	const keyPrice = this.getKeyPrice.metal;
	const newBuyValue = newPrices.buy.toValue(keyPrice);
	const newSellValue = newPrices.sell.toValue(keyPrice);
	// TODO: Use last bought prices instead of current buying prices
	const currBuyingValue = match.buy.toValue(keyPrice);
	const currSellingValue = match.sell.toValue(keyPrice);
	const isNegativeDiff = newSellValue - currBuyingValue < 0;
	if (isNegativeDiff || match.group === 'isPartialPriced') {
	// Only trigger this if difference of new selling price and current buying price is negative
	// Or item group is "isPartialPriced".
	let isUpdate = false;
	if (newBuyValue < currSellingValue) {
	// if new buying price is less than current selling price
	// update only the buying price.
	match.buy = newPrices.buy;
	if (newSellValue > currSellingValue) {
	// If new selling price is more than old, then update selling price too
	match.sell = newPrices.sell;
	}
	isUpdate = true;
	// no need to update time here
	} else if (newSellValue > currSellingValue) {
	// If new selling price is more than old, then update selling price too
	match.sell = newPrices.sell;
	isUpdate = true;
	}
	if (isUpdate) {
	match.group = 'isPartialPriced';
	pricesChanged = true;
	const dw = opt.discordWebhook.sendAlert;
	const isDwEnabled = dw.enable && dw.url !== '';
	const msg =
	`${
	isDwEnabled ? `[${match.name}](https://www.prices.tf/items/${match.sku})` : match.name
	} (${match.sku}):\n▸ ` +
	[
	`old: ${oldPrice.buy.toString()}/${oldPrice.sell.toString()}`,
	`current: ${match.buy.toString()}/${match.sell.toString()}`,
	`pricestf: ${newPrices.buy.toString()}/${newPrices.sell.toString()}`
	].join('\n▸ ');
	if (opt.sendAlert.partialPrice.onUpdate) {
	if (isDwEnabled) {
	sendAlert('isPartialPriced', this.bot, msg);
	} else {
	this.bot.messageAdmins('Partial price update\n\n' + msg, []);
	}
	}
	}
	} else {
	// else, just update as usual now (except if group is "isPartialPriced").
	if (match.group !== 'isPartialPriced') {
	match.buy = newPrices.buy;
	match.sell = newPrices.sell;
	match.time = data.time;
	pricesChanged = true;
	}
	}
	} else {
	// else if optPartialUpdate.enable is false and/or the item is currently not in stock
	// and/or more than threshold, update everything
	match.buy = newPrices.buy;
	match.sell = newPrices.sell;
	match.time = data.time;
	pricesChanged = true;
	if (pricesChanged) {
	this.priceChanged(match.sku, match);
	}

Explanation

• (1) if pricelist.partialPriceUpdate.enable is set to true AND that particular item is currently in stock (> 0) AND difference in time is less than the threshold AND not include excluded items (default only Mann Co. Supply Crate Key),

  • (1.1) if newSelling - currentBuying < 0 OR item group is "isPartialPriced";
    • (1.1.1) if it's determined that the new buying price (prices.tf/custom-autopricer) is less than the current selling price (in pricelist entry), then update ONLY the buying price of that item.
      • (1.1.1.1) then if it's also determined that the new selling price (prices.tf/custom-autopricer) is more than the current selling price (in pricelist entry), then update the selling price of that item too.
    • (1.1.2) else if 1.1.1 false, check if, the new selling price (prices.tf/custom-autopricer) is more than the current selling price (in pricelist entry), then update the selling price of that item.
  • (1.2) else if 1.1 false, update as usual (meaning the new selling price is higher and/or we did not partially price the item before).

• (2) Else, update as usual (disabled and/or not in stock and/or difference in time is more than threshold and/or any of the excluded item (sku).

• The above conditions also applied when the bot starts/restart (updateOldPrices method).

[idinium96]

merging...