🔨 refactor !find command
#387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idinium96
requested review from
arik123,
Bonfire,
Dex-Spirit,
joekiller,
lexidor,
PieDimension,
rennokki,
rocanruca and
SkiLEXx
arik123
requested changes
Mar 1, 2021
There was a problem hiding this comment.
There is no need for 2 different codepaths when sending messages,
put sleep after first message - faster response
I think that some kind of limit would be usefull, maybe add option limit=<value> and if it is set to -1 then it would list all. Also set some good default limit 50-200.
|
Latest commit:
|
arik123
approved these changes
Mar 1, 2021
Merged
idinium96
added a commit
that referenced
this pull request
Mar 3, 2021
#373 ## Added - Options.json related: - ✨option to disable sending the pre-accepted message - @idinium96 - new option added: `offerReceived.sendPreAcceptMessage.enable` (default is `true`) - ✨option to only show price update that is in stock - @idinium96 - new option added: `discordWebhook.priceUpdate.showOnlyInStock` (default is `false`) - ✨an option to partially update item prices if in stock and the difference between the new selling price and current buying price is negative (#284 - read: #337) - @idinium96 - ✨ option to select highValue spells - @idinium96 - new option added: `highValue.spells` (default is `[]` - all spells) - Others: - ✨Docker build for node images (refer: [Wiki](https://github.com/TF2Autobot/tf2autobot/wiki/Running-the-bot-using-docker)) - @rennokki - ✨support **buy order** for skins/war paints (Festivized skins/war paints not supported - see [`#337`](#377)) - @idinium96 - ✨option to disable socket entirely (read: #383) - @idinium96 ## Changed/updated - 🔄 replaced bracket with a dash to not combine with generated URL on retrying to accept offer message sent to admins via Steam Chat - @idinium96 - 🤝 custom-pricer friendly (#363) - @idinium96 - 📝 log bot uptime on auto-restart - @idinium96 - 🔑 ensure selling price for Mann Co. Supply Crate Key never be zero - @idinium96 - 🔄 updated dependencies - @idinium96 - 🔄 improve `!deposit` command (#325, #326) - @idinium96 - 🔄 more flexibility when adding items with parameters - @idinium96 - 🔄 refactor `!find` command (view what changed: #387) - @idinium96 - ✅ do not hold items in an offer for review - @idinium96 - ⏮ revert only pick 1 craft weapon when constructing an offer - @idinium96 ## Fixed - 🔨 wrong position for pure stock and total items in the Offer review send as Discord Webhook. - `!autoadd` command: - 🐛 fix the glitch where the pure got deleted from items dictionary - @idinium96 - ⌚ add a delay before sending `autoadd` summary - @idinium96 - 🔨 fix generic unusual buy order (ensure the generic match is used against 'their' inventory) (#340) - @joekiller - 🔨 fix sending duplicated trade summary - @idinium96 - 🔨 fix failed to disable Autokeys error - @idinium96 - 🐛 fix bot crashed (rare) on startup - @idinium96 - ⛔ do not execute sending price update to Discord Webhook if globalKeyPrices still undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old:
- only show 100 entries if too many.
- show in
/codeand entry form will cause the chat window to lagNew:
sku - name.
.
.