Do not use predefined packages for testing #768
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The complete PR is about testing 😄 But I'm pretty sure, the tests will fail when merged ...
Fix tests
Because of the existing
composer.lock
file and the definition of PHP 7.4 in thecomposer.json
, the tests in the pipeline are always based on the predefined packages. This results in surf not being tested with newer packages that would be used if someone installs surf into their environment via composer.Delete the composer.lock file, which allows the pipeline to install latest packages.
It does not affect any user's installation, but I'm pretty sure, the tests will fail, because there are some problems with newer einvironments (see #760)