Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build issue with version 1.2.2 import undefined.ReactNativeWheelPickerPackage; #39

Open
rt012 opened this issue Jun 9, 2023 · 8 comments

Comments

@rt012
Copy link

rt012 commented Jun 9, 2023

with the version1 12.2 I get following error while building
import undefined.ReactNativeWheelPickerPackage;

"react-native": "0.61.5",

@L96Github
Copy link

I have the same issue.

/Users/runner/work/1/s/android/app/build/generated/rncli/src/main/java/com/facebook/react/PackageList.java:87: error: package undefined does not exist
import undefined.ReactNativeWheelPickerPackage;
                ^
/Users/runner/work/1/s/android/app/build/generated/rncli/src/main/java/com/facebook/react/PackageList.java:169: error: cannot find symbol
      new ReactNativeWheelPickerPackage()
          ^
  symbol:   class ReactNativeWheelPickerPackage
  location: class com.facebook.react.PackageList
2 errors

@solomen5555
Copy link

I have seem issue. "react-native-wheel-pick": "^1.1.0", "react-native": "0.61.5",

@karimelsaidy
Copy link

karimelsaidy commented Jun 12, 2023

same here
"react-native-wheel-pick": "^1.2.1", and "react-native-wheel-pick":"^1.2.2" also produce the same issue
but version '^1.2.0' works fine
"react-native" : "66.4"

@sunilloharshoreline1
Copy link

same here "react-native-wheel-pick": "^1.2.1", and "react-native-wheel-pick":"^1.2.2" also produce the same issue but version '^1.2.0' works fine "react-native" : "66.4"

^1.2.0 doesnt work either.

Any other solution ?

@ra30r
Copy link

ra30r commented Jun 28, 2023

The issue seems to be this commit: 263fa97

Adding back the package name fixes the issue.

@JJSLIoT
Copy link

JJSLIoT commented Jul 14, 2023

Following the changes mentioned by @ra30r I made this patch file:

name: react-native-wheel-pick+1.2.2.patch

diff --git a/node_modules/react-native-wheel-pick/android/src/main/AndroidManifest.xml b/node_modules/react-native-wheel-pick/android/src/main/AndroidManifest.xml
index a2f47b6..b45a8b6 100644
--- a/node_modules/react-native-wheel-pick/android/src/main/AndroidManifest.xml
+++ b/node_modules/react-native-wheel-pick/android/src/main/AndroidManifest.xml
@@ -1,2 +1,3 @@
-<manifest xmlns:android="http://schemas.android.com/apk/res/android">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+  package="com.tron">
 </manifest>

nobelharvards added a commit to nobelharvards/react-native-wheel-pick that referenced this issue Jul 19, 2023
Add package name back to AndroidManifest.xml that was removed in a commit on the 4th of June 2023.

TronNatthakorn@263fa97

Original credit to @ra30r and @JairajJangleSLIOT.

TronNatthakorn#39 (comment)
@manishhedau
Copy link

Hii everyone
I am also facing the same issue while running react-native project in my system
I am using the below versions

"react-native": "0.67.2",
"react-native-wheel-pick": "^1.2.2"

if anyone has any solution for this issue please let us know

@sunilloharshoreline1
Copy link

@manishhedau you will have to create a patch for the react-native-wheel-pick
Change the manifest file from the following path :
node_modules/react-native-wheel-pick/android/src/main/AndroidManifest.xml
to this

<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.tron">
</manifest>

it should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants