Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add package name back to AndroidManifest.xml #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nobelharvards
Copy link

@nobelharvards nobelharvards commented Jul 19, 2023

Add package name back to AndroidManifest.xml that was removed in a commit on the 4th of June 2023.

263fa97

Original credit to @ra30r and @JairajJangleSLIOT.

#39 (comment)

I know @TronNatthakorn has mentioned a few times that this library does not officially support expo, but it turns out the issue is fairly simple.

Without the package name, this happens:

➜  ios git:(develop) ✗ pod install
Using Expo modules
[Expo] Enabling modular headers for pod ExpoModulesCore
error Failed to build the app: No package name found. Found errors in /node_modules/react-native-wheel-pick/android/src/main/AndroidManifest.xml.

[!] Invalid `Podfile` file: 859: unexpected token at 'info Run CLI with --verbose flag for more details.
'.

 #  from /ios/Podfile:14
 #  -------------------------------------------
 #    use_expo_modules!
 >    config = use_native_modules!
 #  
 #  -------------------------------------------

Add package name back to AndroidManifest.xml that was removed in a commit on the 4th of June 2023.

TronNatthakorn@263fa97

Original credit to @ra30r and @JairajJangleSLIOT.

TronNatthakorn#39 (comment)
@nobelharvards nobelharvards marked this pull request as ready for review July 19, 2023 02:32
@dubiao
Copy link

dubiao commented Aug 3, 2023

Not only for the expo. It also reports an error on native android. ref #39
It gives a

import undefined.ReactNativeWheelPickerPackage;

undefined package not found error

Please merge this PR

@talhaakbartws
Copy link

Please merge this branch

@talhaakbartws
Copy link

Please merge this code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants