Fix handling of the dap4: protocol. #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re: Issue The DAP4 code was improperly handling the use of the "dap4:" protocol in a url. This PR fixes it by detecting that protocol and doing two actions: 1. Convert the protocol to "https:". 2. Add the fragment "#dap4" to end of the url. Note that in \Unidata#1, this should really be https, but test.opendap.org still uses http; one hopes that other servers are setup to redirect http: to https: ## PR Checklist <!-- This will become an interactive checklist once the PR is opened --> - [X] Link to any issues that the PR addresses - [X] Add labels - [X] Open as a [draft PR](https://github.blog/2019-02-14-introducing-draft-pull-requests/) until ready for review - [X] Make sure GitHub tests pass - [X] Mark PR as "Ready for Review"
1 task
haileyajohnson
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: Issue #985
Description of Changes
The DAP4 code was improperly handling the use of the "dap4:" protocol in a URL. This PR fixes it by detecting that protocol and doing two actions:
Note that in action 1, this should really be https, but test.opendap.org (a Hyrax server) still accepts only http; one hopes that other servers are setup to redirect http: to https:
PR Checklist