Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of the dap4: protocol. #1255

Merged
merged 1 commit into from
Nov 6, 2023

Commits on Nov 4, 2023

  1. ## Description of Changes

    re: Issue
    
    The DAP4 code was improperly handling the use of the "dap4:"
    protocol in a url. This PR fixes it by detecting that protocol
    and doing two actions:
    1. Convert the protocol to "https:".
    2. Add the fragment "#dap4" to end of the url.
    
    Note that in \Unidata#1, this should really be https, but
    test.opendap.org still uses http; one hopes that other servers
    are setup to redirect http: to https:
    
    ## PR Checklist
    <!-- This will become an interactive checklist once the PR is opened -->
    - [X] Link to any issues that the PR addresses
    - [X] Add labels
    - [X] Open as a [draft PR](https://github.blog/2019-02-14-introducing-draft-pull-requests/) until ready for review
    - [X] Make sure GitHub tests pass
    - [X] Mark PR as "Ready for Review"
    DennisHeimbigner committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    cdd73b0 View commit details
    Browse the repository at this point in the history