Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix(settings): patch regression and refactor a bit #533

Merged
merged 5 commits into from
Jul 4, 2024
Merged

hotfix(settings): patch regression and refactor a bit #533

merged 5 commits into from
Jul 4, 2024

Conversation

Rudxain
Copy link
Member

@Rudxain Rudxain commented Jul 4, 2024

fixes #532

@deepsource-io deepsource.io
Copy link
Contributor

deepsource-io bot commented Jul 4, 2024 •
edited
Loading

Here's the code health analysis summary for commits e500d50..7855b9f. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ Success
🎯 1 occurence resolved
View Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@AnonymousWP AnonymousWP added the bug Something isn't working label Jul 4, 2024
@Rudxain Rudxain changed the title fix(settings): experiment to fix regression hotfix(settings): patch regression an refactor a bit Jul 4, 2024
@Rudxain Rudxain changed the title hotfix(settings): patch regression an refactor a bit hotfix(settings): patch regression and refactor a bit Jul 4, 2024
@Rudxain
Copy link
Member Author

Rudxain commented Jul 4, 2024

I gave up on trying to fix this "properly", so we'll simply use defaults

@Rudxain Rudxain marked this pull request as ready for review July 4, 2024 20:35
@edgy-b edgy-b merged commit 6da6cd1 into Universal-Debloater-Alliance:main Jul 4, 2024
10 of 12 checks passed
@Rudxain Rudxain deleted the hotfix/settings-regression branch July 4, 2024 21:44
@Frigyes06
Copy link
Member

I gave up on trying to fix this "properly", so we'll simply use defaults

I arrived on the same solution lol. It will be fine until it comes around to bite us in the ass somewhere down the line...

@Rudxain
Copy link
Member Author

Rudxain commented Jul 8, 2024

lmao 💀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgy-b edgy-b edgy-b approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(settings): Panic if searching for devices
4 participants
@Rudxain @Frigyes06 @edgy-b @AnonymousWP