Tests/missed tests #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 24 commits
September 8, 2014 15:30
add setters for S3Client and BatchBuilder in the connect function make the upload and connect functions returns boolean
- make the push function return a true in the Cdn Class - update the comment of getConfigurations in the CdnHelper class - update the comment of getAssets in the Asset class
add main validator to hold the shared function between all validators, and add a CdnFacadeValidator to hold the validation of the CdnFacade class.
validate the asset() function doesn't have an empty $path
and make it extends validator
to become Vinelab\Cdn\Validators\Contracts\ProviderValidator after renaming the validator class
class name is EmptyInputException
class. The new dependency is the validator class
the test covers empty default provider
To be the same as the of the class being tested
To be the same as the of the class being tested
- write tests for the asset class - make the parseAndFillConfiguration private - change the asset properties to protected (since they all have getters)
This will fix the reading of the config file form the framework not the package
Mulkave
added a commit
that referenced
this pull request
Sep 9, 2014
- fix the reading of the config file. - write unit tests for all the classes. - add validator classes and make them extends main validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainly just adding testings