Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/missed tests #17

Merged
merged 24 commits into from
Sep 9, 2014
Merged

Tests/missed tests #17

merged 24 commits into from
Sep 9, 2014

Commits on Sep 8, 2014

  1. Configuration menu
    Copy the full SHA
    ab2d7a2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    abb9cb0 View commit details
    Browse the repository at this point in the history
  3. add testing for files upload

    add setters for S3Client and BatchBuilder in the connect function
    make the upload and connect functions returns boolean
    mahmoud committed Sep 8, 2014
    Configuration menu
    Copy the full SHA
    5b50d42 View commit details
    Browse the repository at this point in the history
  4. add testing for the push command

    - make the push function return a true in the Cdn Class
    - update the comment of getConfigurations in the CdnHelper class
    - update the comment of getAssets in the Asset class
    mahmoud committed Sep 8, 2014
    Configuration menu
    Copy the full SHA
    d5122eb View commit details
    Browse the repository at this point in the history
  5. add testing for the facade url generator

    mahmoud committed Sep 8, 2014
    Configuration menu
    Copy the full SHA
    3b0d039 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2014

  1. add validators

    add main validator to hold the shared function between all validators,
    and add a CdnFacadeValidator to hold the validation of the CdnFacade
    class.
    mahmoud committed Sep 9, 2014
    Configuration menu
    Copy the full SHA
    287a56e View commit details
    Browse the repository at this point in the history
  2. add validation

    validate the asset() function doesn't have an empty $path
    mahmoud committed Sep 9, 2014
    Configuration menu
    Copy the full SHA
    918ce2b View commit details
    Browse the repository at this point in the history
  3. rename configuration cass (validator) to ProviderValidator

    and make it extends validator
    mahmoud committed Sep 9, 2014
    Configuration menu
    Copy the full SHA
    25bcb68 View commit details
    Browse the repository at this point in the history
  4. update usage of Vinelab\Cdn\Validators\Contracts\Configurations

    to become Vinelab\Cdn\Validators\Contracts\ProviderValidator
    
    after renaming the validator class
    mahmoud committed Sep 9, 2014
    Configuration menu
    Copy the full SHA
    50a48bb View commit details
    Browse the repository at this point in the history
  5. add exception class to be trow when a function input is missed

    class name is EmptyInputException
    mahmoud committed Sep 9, 2014
    Configuration menu
    Copy the full SHA
    bdc07a2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    089388a View commit details
    Browse the repository at this point in the history
  7. update the FacadeTest after injecting new dependency to the CdnFacade

    class.
    
    The new dependency is the validator class
    mahmoud committed Sep 9, 2014
    Configuration menu
    Copy the full SHA
    5a20550 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f480446 View commit details
    Browse the repository at this point in the history
  9. add testing for null asset parameter

    mahmoud committed Sep 9, 2014
    Configuration menu
    Copy the full SHA
    7b2d033 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    4bad486 View commit details
    Browse the repository at this point in the history
  11. remove checkIfEmpty from the Validator class

    mahmoud committed Sep 9, 2014
    Configuration menu
    Copy the full SHA
    98ee6ee View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    83886ec View commit details
    Browse the repository at this point in the history
  13. add tests for the providers factory create

    the test covers empty default provider
    mahmoud committed Sep 9, 2014
    Configuration menu
    Copy the full SHA
    e7f32ea View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    0e6badf View commit details
    Browse the repository at this point in the history
  15. rename the FacadeTest to CdnFacadeTest

    To be the same as the of the class being tested
    mahmoud committed Sep 9, 2014
    Configuration menu
    Copy the full SHA
    0cbeea5 View commit details
    Browse the repository at this point in the history
  16. rename the AwsS3Test to AwsS3ProviderTest

    To be the same as the of the class being tested
    mahmoud committed Sep 9, 2014
    Configuration menu
    Copy the full SHA
    b36f9f5 View commit details
    Browse the repository at this point in the history
  17. add tests for the asset class

    - write tests for the asset class
    - make the parseAndFillConfiguration private
    - change the asset properties to protected (since they all have getters)
    mahmoud committed Sep 9, 2014
    Configuration menu
    Copy the full SHA
    739076d View commit details
    Browse the repository at this point in the history
  18. fix the asset() by checking if parameter isset

    mahmoud committed Sep 9, 2014
    Configuration menu
    Copy the full SHA
    8e588f9 View commit details
    Browse the repository at this point in the history
  19. add register the package (for the config files) in the Service Provider.

    This will fix the reading of the config file form the framework
    not the package
    mahmoud committed Sep 9, 2014
    Configuration menu
    Copy the full SHA
    e8d6676 View commit details
    Browse the repository at this point in the history