-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests/missed tests #17
Commits on Sep 8, 2014
-
fix keeping history of uploaded files after each flash
mahmoud committedSep 8, 2014 Configuration menu - View commit details
-
Copy full SHA for ab2d7a2 - Browse repository at this point
Copy the full SHA ab2d7a2View commit details -
add testing for provider initialization testInitializingObject
mahmoud committedSep 8, 2014 Configuration menu - View commit details
-
Copy full SHA for abb9cb0 - Browse repository at this point
Copy the full SHA abb9cb0View commit details -
add setters for S3Client and BatchBuilder in the connect function make the upload and connect functions returns boolean
mahmoud committedSep 8, 2014 Configuration menu - View commit details
-
Copy full SHA for 5b50d42 - Browse repository at this point
Copy the full SHA 5b50d42View commit details -
add testing for the push command
- make the push function return a true in the Cdn Class - update the comment of getConfigurations in the CdnHelper class - update the comment of getAssets in the Asset class
mahmoud committedSep 8, 2014 Configuration menu - View commit details
-
Copy full SHA for d5122eb - Browse repository at this point
Copy the full SHA d5122ebView commit details -
add testing for the facade url generator
mahmoud committedSep 8, 2014 Configuration menu - View commit details
-
Copy full SHA for 3b0d039 - Browse repository at this point
Copy the full SHA 3b0d039View commit details
Commits on Sep 9, 2014
-
add main validator to hold the shared function between all validators, and add a CdnFacadeValidator to hold the validation of the CdnFacade class.
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for 287a56e - Browse repository at this point
Copy the full SHA 287a56eView commit details -
validate the asset() function doesn't have an empty $path
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for 918ce2b - Browse repository at this point
Copy the full SHA 918ce2bView commit details -
rename configuration cass (validator) to ProviderValidator
and make it extends validator
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for 25bcb68 - Browse repository at this point
Copy the full SHA 25bcb68View commit details -
update usage of Vinelab\Cdn\Validators\Contracts\Configurations
to become Vinelab\Cdn\Validators\Contracts\ProviderValidator after renaming the validator class
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for 50a48bb - Browse repository at this point
Copy the full SHA 50a48bbView commit details -
add exception class to be trow when a function input is missed
class name is EmptyInputException
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for bdc07a2 - Browse repository at this point
Copy the full SHA bdc07a2View commit details -
add missed public functions to validator interfaces
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for 089388a - Browse repository at this point
Copy the full SHA 089388aView commit details -
update the FacadeTest after injecting new dependency to the CdnFacade
class. The new dependency is the validator class
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for 5a20550 - Browse repository at this point
Copy the full SHA 5a20550View commit details -
add if condition to check if $path exist in the asset() function
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for f480446 - Browse repository at this point
Copy the full SHA f480446View commit details -
add testing for null asset parameter
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for 7b2d033 - Browse repository at this point
Copy the full SHA 7b2d033View commit details -
rename the exception EmptyInputException to EmptyPathException
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for 4bad486 - Browse repository at this point
Copy the full SHA 4bad486View commit details -
remove checkIfEmpty from the Validator class
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for 98ee6ee - Browse repository at this point
Copy the full SHA 98ee6eeView commit details -
add tests for the providers factory class (testAwsS3ProviderCreation)
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for 83886ec - Browse repository at this point
Copy the full SHA 83886ecView commit details -
add tests for the providers factory create
the test covers empty default provider
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for e7f32ea - Browse repository at this point
Copy the full SHA e7f32eaView commit details -
add test for empty /public directory when reading allowed directories
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for 0e6badf - Browse repository at this point
Copy the full SHA 0e6badfView commit details -
rename the FacadeTest to CdnFacadeTest
To be the same as the of the class being tested
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for 0cbeea5 - Browse repository at this point
Copy the full SHA 0cbeea5View commit details -
rename the AwsS3Test to AwsS3ProviderTest
To be the same as the of the class being tested
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for b36f9f5 - Browse repository at this point
Copy the full SHA b36f9f5View commit details -
- write tests for the asset class - make the parseAndFillConfiguration private - change the asset properties to protected (since they all have getters)
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for 739076d - Browse repository at this point
Copy the full SHA 739076dView commit details -
fix the asset() by checking if parameter isset
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for 8e588f9 - Browse repository at this point
Copy the full SHA 8e588f9View commit details -
add register the package (for the config files) in the Service Provider.
This will fix the reading of the config file form the framework not the package
mahmoud committedSep 9, 2014 Configuration menu - View commit details
-
Copy full SHA for e8d6676 - Browse repository at this point
Copy the full SHA e8d6676View commit details