Merge pull request #5112 from talentlessguy/dedupe-fetch

chore: partially dedupe fetch implementations and use native fetch instead
WalletConnect · Aug 15, 2024 · f9aea5b · f9aea5b
2 parents ab408aa + 2dc426e
commit f9aea5b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 131 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -45,12 +45,13 @@
     "@walletconnect/types": "2.14.0",
     "@walletconnect/utils": "2.14.0",
     "events": "3.3.0",
-    "isomorphic-unfetch": "3.1.0",
     "lodash.isequal": "4.5.0",
     "uint8arrays": "3.1.0"
   },
   "devDependencies": {
-    "@types/lodash.isequal": "4.5.6",
-    "node-fetch": "3.3.0"
+    "@types/lodash.isequal": "4.5.6"
+  },
+  "engines": {
+    "node": ">=18"
   }
 }
diff --git a/packages/core/src/controllers/echo.ts b/packages/core/src/controllers/echo.ts
@@ -1,7 +1,6 @@
 import { generateChildLogger, Logger } from "@walletconnect/logger";
 import { IEchoClient } from "@walletconnect/types";
 import { ECHO_CONTEXT, ECHO_URL } from "../constants";
-import fetch from "isomorphic-unfetch";
 
 export class EchoClient extends IEchoClient {
   public readonly context = ECHO_CONTEXT;

diff --git a/packages/core/test/verify.spec.ts b/packages/core/test/verify.spec.ts
@@ -1,5 +1,4 @@
 import { expect, describe, it } from "vitest";
-import fetch from "node-fetch";
 import { hashMessage } from "@walletconnect/utils";
 
 import { Core, VERIFY_SERVER } from "../src";