Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: partially dedupe fetch implementations and use native fetch instead #5112

Merged
merged 8 commits into from
Aug 15, 2024
Merged

chore: partially dedupe fetch implementations and use native fetch instead #5112

merged 8 commits into from
Aug 15, 2024

Conversation

talentlessguy
Copy link
Contributor

Description

This PR removes a few duplicate fetch implementations from WC and keeps only the ones by subdependencies (since downstream projects have to remove them). Instead packages now would use native fetch. It also puts a node 18.x requirement for fetch.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

Unit tests.

Fixes/Resolves (Optional)

Fixes #5102

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@ganchoradkov
Copy link
Member

hey, thanks for the PR 💯 I will test and get back as the SDK has to work on every JS env and want to confirm removing fetch doesn't cause regressions

@talentlessguy
Copy link
Contributor Author

@ganchoradkov thanks for taking time to look. If you have time please take a look at #5104 as well, it's another PR to reduce dep count

@talentlessguy
Copy link
Contributor Author

talentlessguy commented Jul 3, 2024 •
edited
Loading

also it shouldn't break anything because WalletConnect uses fixed version tags from what I understand, instead of any kind of aliases such as "latest", and also because as long as you don't upgrade nothing's gonna break. If you upgrade, it'll only break if you're using node older than 18 and you don't have a global polyfill set up.

ganchoradkov
ganchoradkov approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@ganchoradkov ganchoradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the improvement 💯

@talentlessguy
Copy link
Contributor Author

@ganchoradkov thanks for approving! there's some unrelated test failing, what should I do about it?

@talentlessguy
Copy link
Contributor Author

@ganchoradkov is there anything blocking the PR?

@ganchoradkov ganchoradkov merged commit f9aea5b into WalletConnect:v2.0 Aug 15, 2024
3 of 9 checks passed
@ganchoradkov
Copy link
Member

thank you for the PR again and sorry for the delay!

@ganchoradkov ganchoradkov mentioned this pull request Aug 15, 2024
Merged
20 tasks
@talentlessguy talentlessguy deleted the dedupe-fetch branch August 15, 2024 16:51
github-merge-queue bot referenced this pull request in valora-inc/wallet Aug 20, 2024
@renovate
chore(deps): update dependency @walletconnect/react-native-compat to …
4d5d700 
…^2.15.0 (#5795)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@walletconnect/react-native-compat](https://github.com/walletconnect/walletconnect-monorepo)
| [`^2.14.0` ->
`^2.15.0`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.14.0/2.15.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2freact-native-compat/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2freact-native-compat/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2freact-native-compat/2.14.0/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2freact-native-compat/2.14.0/2.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>walletconnect/walletconnect-monorepo
(@&#8203;walletconnect/react-native-compat)</summary>

###
[`v2.15.0`](https://github.com/WalletConnect/walletconnect-monorepo/releases/tag/2.15.0)

[Compare
Source](https://github.com/walletconnect/walletconnect-monorepo/compare/2.14.0...2.15.0)

#### What's Changed

- chore: prep for `2.14.0` release by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5195](https://github.com/WalletConnect/walletconnect-monorepo/pull/5195)
- refactor: removes session approval peer acknowledgment delay by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5197](https://github.com/WalletConnect/walletconnect-monorepo/pull/5197)
- chore(deps): update docker/build-push-action action to v6 by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/4641](https://github.com/WalletConnect/walletconnect-monorepo/pull/4641)
- chore(deps): update actions/add-to-project action to v1.0.2 by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5101](https://github.com/WalletConnect/walletconnect-monorepo/pull/5101)
- chore: fix some comments by
[@&#8203;renshuncui](https://github.com/renshuncui) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/4640](https://github.com/WalletConnect/walletconnect-monorepo/pull/4640)
- AlgorandProvider
[#&#8203;877](https://github.com/walletconnect/walletconnect-monorepo/issues/877)
[#&#8203;2760](https://github.com/walletconnect/walletconnect-monorepo/issues/2760)
by [@&#8203;scholtz](https://github.com/scholtz) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5201](https://github.com/WalletConnect/walletconnect-monorepo/pull/5201)
- chore: fix typo by
[@&#8203;riyueguang](https://github.com/riyueguang) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5216](https://github.com/WalletConnect/walletconnect-monorepo/pull/5216)
- chore: change handshake canary to only measure 1 client initialization
by [@&#8203;chris13524](https://github.com/chris13524) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5250](https://github.com/WalletConnect/walletconnect-monorepo/pull/5250)
- refactor: session settle response by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5259](https://github.com/WalletConnect/walletconnect-monorepo/pull/5259)
- refactor: publishes session settle request before the session propose…
by [@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5246](https://github.com/WalletConnect/walletconnect-monorepo/pull/5246)
- feat: verify v2 by
[@&#8203;ganchoradkov](https://github.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5236](https://github.com/WalletConnect/walletconnect-monorepo/pull/5236)
- chore: partially dedupe fetch implementations and use native fetch
instead by [@&#8203;talentlessguy](https://github.com/talentlessguy)
in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5112](https://github.com/WalletConnect/walletconnect-monorepo/pull/5112)

#### New Contributors

- [@&#8203;renshuncui](https://github.com/renshuncui) made their first
contribution in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/4640](https://github.com/WalletConnect/walletconnect-monorepo/pull/4640)
- [@&#8203;scholtz](https://github.com/scholtz) made their first
contribution in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5201](https://github.com/WalletConnect/walletconnect-monorepo/pull/5201)
- [@&#8203;riyueguang](https://github.com/riyueguang) made their first
contribution in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5216](https://github.com/WalletConnect/walletconnect-monorepo/pull/5216)
- [@&#8203;talentlessguy](https://github.com/talentlessguy) made their
first contribution in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/5112](https://github.com/WalletConnect/walletconnect-monorepo/pull/5112)

**Full Changelog**:
WalletConnect/walletconnect-monorepo@2.14.0...2.15.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsibnBtIiwicmVub3ZhdGUiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <valorabot@valoraapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganchoradkov ganchoradkov Awaiting requested review from ganchoradkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate fetch dependencies across WalletConnect SDK
2 participants
@talentlessguy @ganchoradkov