Use resources in wasi-http #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottt
force-pushed
the
trevor/match-wasmtime
branch
from
0a8b941
to
8584f46
Compare
elliottt
changed the title
elliottt
force-pushed
the
trevor/match-wasmtime
branch
from
8584f46
to
b154def
Compare
lukewagner
approved these changes
Oct 17, 2023
| /// are ready to be consumed. | ||
| subscribe: func() -> pollable; | ||
|
|
||
| /// Retrieve reference to trailers, if they are ready. |
There was a problem hiding this comment.
It looks like you're switching to doc-comments in a few places, but not all. It seems like we should be all-doc-comments or no-doc-comments (which is making me ask once again: why is this a valuable choice?!).
There was a problem hiding this comment.
I think it would be worthwhile to make all comments doc comments: all the comments we write now are meant to document the api interface, instead of remain as notes for future readers.
elliottt
force-pushed
the
trevor/match-wasmtime
branch
from
5342d24
to
44de215
Compare
Co-authored-by: Luke Wagner <mail@lukewagner.name>
elliottt
force-pushed
the
trevor/match-wasmtime
branch
from
9aaf275
to
bc7b85f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert all pseudo-resources to full resources, and as such introduces some
borrow<..>annotations.Additionally, this reworks body handling to go through an intermediate resource, rather than expose direct access to the underlying stream for the request/response resource. This intermediate resource allows us to better track when trailers are expected to be written or read.