Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Library: Table: Consider "Fixed width table cells" as default #16045

Closed
Tracked by #32400
aduth opened this issue Jun 7, 2019 · 1 comment · Fixed by #49672
Closed
Tracked by #32400

Block Library: Table: Consider "Fixed width table cells" as default #16045

aduth opened this issue Jun 7, 2019 · 1 comment · Fixed by #49672
Assignees
Labels
[Block] Table Affects the Table Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@aduth
Copy link
Member

aduth commented Jun 7, 2019

The table block supports an option for "Fixed width table cells", which changes the appearance of the table so that each column occupies an equal amount of width.

More information about table-layout: fixed: https://developer.mozilla.org/en-US/docs/Web/CSS/table-layout

Arguably, this would be the more expected default use-case, and as such we should consider to make this the default behavior.

Implementation Notes:

Since this is a change in the default behavior, we should be careful to consider how we want backwards-compatibility to apply. If users have saved content with the current default setting and have expectations around the non-fixed behavior, these expectations should not be broken. Conversely, part of the intent of the defaults implementation of blocks (core blocks specifically) is to allow for revisions to these defaults to more sensible ones in future revisions.

Needs Feedback: Are we okay in changing the default for existing, saved content?

If existing defaults must be preserved, we should consider how we'd plan to version this, whether that be by introducing a new separate attribute, or some other way to identify the older content for the new default to take effect.

@aduth aduth added [Type] Enhancement A suggestion for improvement. Needs Decision Needs a decision to be actionable or relevant [Block] Table Affects the Table Block labels Jun 7, 2019
@mtias mtias added [Type] Task Issues or PRs that have been broken down into an individual action to take Good First Issue An issue that's suitable for someone looking to contribute for the first time and removed Needs Decision Needs a decision to be actionable or relevant labels Nov 17, 2019
@mtias
Copy link
Member

mtias commented Nov 17, 2019

This makes sense to me, I find the current behaviour odd.

karmatosed pushed a commit that referenced this issue Dec 2, 2019
I have added this to both the editor and also to the front styles. It might be a point for discussion along with should this be done, but also would the editor and theme show it?

Fixes #16045
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 2, 2019
@karmatosed karmatosed removed their assignment Dec 2, 2019
@skorasaurus skorasaurus removed the [Status] In Progress Tracking issues with work in progress label Jan 20, 2023
@t-hamano t-hamano self-assigned this Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Table Affects the Table Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
5 participants