Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't select aligned images #21114

Closed
draganescu opened this issue Mar 24, 2020 · 4 comments
Closed

Can't select aligned images #21114

draganescu opened this issue Mar 24, 2020 · 4 comments
Assignees
@roo2
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended
Milestone
Gutenberg 7.9

Comments

@draganescu
Copy link
Contributor

Describe the bug
If an image block is aligned and there is some text that floats in the remaining space the image can't be selected with the mouse anymore.

*To reproduce

  1. Add a page
  2. Add an image
  3. Add some text below the image
  4. Resize the image to 50% of text width
  5. Align the image right
    6 Observe the bug

Expected behavior
I should be able to click on the image to select it.

Screenshots
image-select

Desktop (please complete the following information):

  • OS: OSX
  • Browser Firefox
  • Version 74

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

  • Please add the version of Gutenberg you are using in the description.
  • To report a security issue, please visit the WordPress HackerOne program: https://hackerone.com/wordpress.
@draganescu draganescu added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block labels Mar 24, 2020
@draganescu draganescu added this to the Gutenberg 7.9 milestone Mar 24, 2020
@draganescu draganescu added the Needs Dev Ready for, and needs developer efforts label Mar 24, 2020
@strarsis
Copy link
Contributor

+1, same issue. Can be reproduced in Frontenberg Gutenberg demo.

@kathrynwp
Copy link

Can replicate in Firefox 74.0 (64-bit), macOS 10.14.6

Another person replicated in Chrome 80.0.3987.149 (Official Build) (64-bit), OS unknown

@ccwalburn ccwalburn mentioned this issue Mar 25, 2020
Closed
@roo2
Copy link
Contributor

roo2 commented Mar 25, 2020 •
edited
Loading

PR to fix this: #21160

@roo2 roo2 mentioned this issue Mar 26, 2020
Merged
6 tasks
roo2 added a commit to roo2/gutenberg that referenced this issue Mar 26, 2020
@roo2
Revert "Light block: automatically add block class (WordPress#20658)"…
9987674 
… due to issues:

WordPress#21152
WordPress#21114

This reverts commit 8a94254.
@roo2 roo2 mentioned this issue Mar 26, 2020
Closed
6 tasks
@draganescu draganescu removed the Needs Dev Ready for, and needs developer efforts label Mar 26, 2020
@draganescu
Copy link
Contributor Author

Fixed by #21167 (props @ellatrix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roo2 roo2

Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 7.9
Development

Successfully merging a pull request may close this issue.

Revert #20658 due to issues with image placement and selection roo2/gutenberg
4 participants
@draganescu @kathrynwp @strarsis @roo2