Light block: automatically add block class #20658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
ajitbohra,
jorgefilipecosta,
nerrad,
ntwb,
Soean,
talldan and
youknowriad
as code owners
|
Size Change: +23 B (0%) Total Size: 863 kB
ℹ️ View Unchanged
|
|
@youknowriad This is based on your feedback here: #19910 (comment). |
youknowriad
reviewed
Mar 5, 2020
youknowriad
approved these changes
Mar 5, 2020
|
Thanks! |
See #20849 for more details. It needs to be validated. |
|
I locally tracked an issue with image selection down to this change, I'm looking into getting it working at the moment or if we can revert #21114 |
roo2
added a commit
to roo2/gutenberg
that referenced
this pull request
Mar 26, 2020
… due to issues: WordPress#21152 WordPress#21114 This reverts commit 8a94254.
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the need for a light block to add the auto generated class name to the editor block DOM. This class name can be automatically added in the
Block.*component, based on support for this class name.This PR also removes the
wp-block-paragraphclass from the paragraph block in the editor, since the block opts out. I'm not sure why this was hardcoded.How has this been tested?
Screenshots
Types of changes
Checklist: