Update ColorPalette component to accept disableAlpha parameter #18175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the disableAlpha parameter to ColorPalette component which is passed forward to the ColorPicker to show. Previously it was set to true by default. Fixes #4726
mkaz
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta,
talldan and
youknowriad
as code owners
mkaz
added
[Package] Components
gziolo
approved these changes
Oct 30, 2019
youknowriad
reviewed
Oct 31, 2019
| @@ -55,7 +56,7 @@ export default function ColorPalette( { | |||
| <ColorPicker | |||
| color={ value } | |||
| onChangeComplete={ ( color ) => onChange( color.hex ) } | |||
There was a problem hiding this comment.
As far as I know hex colors format don't include "alpha" information in it. This make me think this PR is not complete yet as there's no way for the users of this component to get the value of the selected alpha.
Should we switch to rgba if disableAlpha is false? should we do it every time? do we need a format prop? should we pass the whole color object. These are all options.
There was a problem hiding this comment.
ah... that might explain why it was disabled in the first place.
I think we should revert and then we can add to address other issues.
I prepped this PR for the revert: #18220
mkaz
added a commit
that referenced
this pull request
Oct 31, 2019
youknowriad
pushed a commit
that referenced
this pull request
Nov 11, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the disableAlpha parameter to ColorPalette component which is passed forward to the ColorPicker to show. Previously it was set to true by default.
Fixes #4726
How has this been tested?
Run
npm run design-system:devto view component in Storybook.Click custom color and confirm the Alpha channel shows up.
Screenshots
Types of changes
Update ColorPalette component previously hard-coded to false when using the ColorPicker, this allows the parameter to be set by user.
Checklist: