Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorPalette: enable alpha channel #4726

Closed
axmetov opened this issue Jan 29, 2018 · 3 comments · Fixed by #18175
Closed

ColorPalette: enable alpha channel #4726

axmetov opened this issue Jan 29, 2018 · 3 comments · Fixed by #18175
Labels
Customization Issues related to Phase 2: Customization efforts Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Milestone
Future

Comments

@axmetov
Copy link

axmetov commented Jan 29, 2018

Issue Overview

The Color Palette block restricts the alpha editing for colors. It will be very useful to make the attribute to enable/disable alpha while it is just the one parameter on React Color.

Expected Behavior

The simple attribute passed on the block creation.
<ColorPalette disableAlpha={ false } />

Current Behavior

At the moment, the alpha is restricted in ChromePicker creation in the block.
<ChromePicker color={ value } onChangeComplete={ ( color ) => onChange( color.hex ) } style={ { width: '100%' } } **disableAlpha** />

Screenshots

Used to be.
image
@karmatosed karmatosed added the [Type] Enhancement A suggestion for improvement. label Jan 30, 2018
@karmatosed
Copy link
Member

On one hand I like the simplicity we have now, but I can see how this could be useful for some. I think it's potentially good to offer, thanks for suggesting.

@nk-o
Copy link
Contributor

nk-o commented Feb 21, 2018

@karmatosed, simplicity is good for default blocks, don't need to enable alpha for it. Just give an option to enable it in custom blocks. Waiting for this option :)

@bordoni bordoni mentioned this issue Mar 4, 2018
Closed
3 tasks
@karmatosed karmatosed modified the milestones: Merge Proposal: Editor, Bonus Features Apr 27, 2018
@mcsf mcsf mentioned this issue Jul 18, 2018
Closed
@ryelle ryelle mentioned this issue Oct 2, 2018
Closed
@mtias mtias added Future Customization Issues related to Phase 2: Customization efforts and removed Future labels Oct 7, 2018
@ryelle ryelle mentioned this issue Oct 12, 2018
Merged
4 tasks
@youknowriad youknowriad modified the milestone: Future Mar 25, 2019
@diegoliv diegoliv mentioned this issue Apr 24, 2019
Closed
@gziolo gziolo added Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts labels Apr 24, 2019
@gziolo
Copy link
Member

gziolo commented Apr 24, 2019

There is prior work which can be reused to fix resolve this issue. See #7151 proposed by @diegoliv.

@mkaz mkaz mentioned this issue Oct 29, 2019
Merged
5 tasks
mkaz added a commit that referenced this issue Oct 30, 2019
@mkaz
Update ColorPalette component to accept disableAlpha parameter (#18175)
96f7d34 
* Add disableAlpha parameter to ColorPalette

Adds the disableAlpha parameter to ColorPalette component which is
passed forward to the ColorPicker to show. Previously it was set to true
by default. Fixes #4726

* Update documentation with disableAlpha parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Customization Issues related to Phase 2: Customization efforts Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Future
6 participants
@karmatosed @youknowriad @mtias @gziolo @nk-o @axmetov