Allow custom ColorPalette to enable Alpha Channel #5382
Conversation
| @@ -61,7 +61,7 @@ export function ColorPalette( { colors, disableCustomColors = false, value, onCh | |||
| color={ value } | |||
| onChangeComplete={ ( color ) => onChange( color.hex ) } | |||
| style={ { width: '100%' } } | |||
| disableAlpha | |||
There was a problem hiding this comment.
Thanks for your work on this PR but I have a concern here.
If we were to introduce this prop, why should we use it only in the ChromePicker and not for the palette colors as well?
Also, This doesn't affect the color value, since we only pass the color.hex value on the onChange call.
Can't we just keep this component as is and use a separate RangeControl if we want to tweak the alpha value? Alternatively, you can still use the ChromePicker directly in your components?
There was a problem hiding this comment.
I feel like both of the points about extending ChromePicker by yourself and RangeControl are valid.
My only point towards adding is more on the side of just making the internal Components more re-usable and less of copy the whole file into your project because some params are not exposed.
Will apply onChange modification, if you think it's worth making internal components more extendable just because.
|
Closing in favor of #5835 |
Description
Resolves #4726
How Has This Been Tested?
Used internally on my own custom block for testing, and it didn't break any of the existing
ColorPaletteusaged.Types of changes
Introduced a way to allow
ColorPaletteto have Alpha Channels enabled by third-party developers.Checklist: