Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile][Monorepo] import of gutenberg-mobile (with history of commits) #19706

Merged

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Jan 16, 2020

Explores #11491.
Tries again #18508 which was squashed and thus is preventing us from pulling new commits from gutenberg-mobile

This is a migration of gutenberg-mobile to gutenberg repository with git history.

How has this been tested?

At this stage, there is nothing to test.
This PR is just there so we can merge the whole https://github.com/wordpress-mobile/gutenberg-mobile repository into packages/react-native-editor with all its history, so subsequent PRs changes are minimized.
For this the following PR was run:

git subtree add --prefix packages/react-native-editor git@github.com:wordpress-mobile/gutenberg-mobile.git develop

Any subsequent update from gutenberg-mobile can be done using:

git subtree pull --prefix packages/react-native-editor git@github.com:wordpress-mobile/gutenberg-mobile.git develop

We will not attempt to fix any of the errors that arise from this merge, thus the reason why we're not targeting master but a feature branch instead

maxme and others added 30 commits November 29, 2019 15:25
…ection-handling

Use plural method for multiple media selection handling
@Tug Tug added the [Type] Technical Prototype Offers a technical exploration into an idea as an example of what's possible label Jan 16, 2020
@Tug Tug requested review from maxme and dratwas January 16, 2020 15:42
@Tug Tug self-assigned this Jan 16, 2020
@Tug Tug changed the title Rnmobile/import mobile no squash [RNMobile][Monorepo] import of gutenberg-mobile (with history of commits) Jan 16, 2020
@Tug Tug requested a review from gziolo January 16, 2020 15:43
@dratwas
Copy link
Contributor

dratwas commented Jan 16, 2020

LGTM 🎉

@Tug
Copy link
Contributor Author

Tug commented Jan 16, 2020

@gziolo would you be able to merge this without squashing the commits please?

@gziolo
Copy link
Member

gziolo commented Jan 16, 2020

@gziolo would you be able to merge this without squashing the commits please?

it's disabled, we need someone with the owner role – @youknowriad or @mtias?

@youknowriad youknowriad merged commit 7e153d0 into feat/import-gutenberg-mobile-no-squash Jan 17, 2020
@youknowriad youknowriad deleted the rnmobile/import-mobile-no-squash branch January 17, 2020 09:22
@ellatrix ellatrix added this to the Gutenberg 7.3 milestone Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Technical Prototype Offers a technical exploration into an idea as an example of what's possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.