Fix Twenty Twenty One related e2e test failures #26341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
the
[Type] Automated Testing
talldan
requested review from
ajitbohra,
gziolo,
nerrad and
ntwb
as code owners
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
|
Still some failures happening:
These, except for the pattern test, seem related to loading/saving/entities in general. |
From what I can see, this is failing because on this line: insertion of the Template Part fails. |
…, which takes up less space on screen
talldan
force-pushed
the
fix/twenty-twenty-one-e2e-tests
branch
from
2ef7b2d
to
c4f837b
Compare
talldan
changed the title
6 tasks
tellthemachines
pushed a commit
that referenced
this pull request
Oct 27, 2020
* Account for unknown number of controls in block inspector * Ensure selection is on-screen by using a group block instead of cover, which takes up less space on screen * Fix typewriter test * Use correct name for patterns test * Revert change to .wp-env.json * Fix multi-entity side editor saving test * Remove blank line
tellthemachines
added a commit
that referenced
this pull request
Oct 27, 2020
* Fix drop zone indicators for non blocks (#25986) * Remove isDraggingBlocks check * Clean up drag and drop data if the user presses escape when dragging * Add comment to ensure avoidance of dragend * Switch to using dragend * Fix archives block render function (#26309) * Code block: preserve indentation on paste (#26347) * Turn off autocomplete for token input. (#26427) * Fix parent post selector: ensure initial value available, search performed, all results shown. (#26397) Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> * [RNMobile] Fix CI issues during `npm ci` (#26455) * Run mobile tests on master * Debug CI * Revert "Debug CI" This reverts commit dec1ebe. * Update react-native-screens ref, pin @react-navigation/native version * Pin @react-navigation/core,router versions * Fix composer test failures due to invalid lock (#26472) * Fix gallery block undo issue (#26377) * Mark change in attributes when gallery mounts as not persistant * Fix typo * Fix package lock changes * Fix some Twenty Twenty One related e2e test failures (#26341) * Account for unknown number of controls in block inspector * Ensure selection is on-screen by using a group block instead of cover, which takes up less space on screen * Fix typewriter test * Use correct name for patterns test * Revert change to .wp-env.json * Fix multi-entity side editor saving test * Remove blank line * insert paragraph instead of tempalte part (#26371) * Fix autosave e2e tests (#26416) * Update how block to render is tracked (#26356) Co-authored-by: Daniel Richards <daniel.richards@automattic.com> Co-authored-by: Riad Benguella <benguella@gmail.com> Co-authored-by: Ella van Durpe <wp@iseulde.com> Co-authored-by: Adam Silverstein <adamsilverstein@earthboundhosting.com> Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com> Co-authored-by: Marcus Kazmierczak <marcus@mkaz.com> Co-authored-by: Addison Stavlo <Stavz01@gmail.com> Co-authored-by: O André <nosolosw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempts at fixing failing end to end tests.
Some of these are failing because the theme in the testing environment is now Twenty Twenty One. Some of the assumptions made in tests are now wrong:
Navigating the block hierarchy › should navigate block hierarchy using only the keyboard- this test was assuming that the column count RangeControl would be 5 tab stops into the columns block's inspector controls. But Twenty Twenty One adds some block styles to columns, so the test has now been updated to press tab until the column count RangeControl is focused.TypeWriter › should scroll caret into view from the top- harder to track down, but I think this was failing because the paragraph font size in Twenty Twenty One is slightly larger. The page wasn't scrolling enough to take this into account.Multi-block selection › should select by dragging into nested block- I think this is similar to the above, the paragraph inside the cover block is half off-screen, seems like enough so that dragging to it doesn't work correctly, but not enough for the browser to scroll to it. I switched to a group block, but an alternative could be to scroll down after inserting the cover.There were two that I haven't been able to reproduce locally:
adding patterns › should insert a block pattern- This may be happening because patterns load in asynchronously and the test is moving too quickly.adding blocks › Should insert content using the placeholder and the regular inserter- Couldn't spot any potential issues, but it has been failing inmaster.