Fix composer test failures due to invalid lock #26472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dealerdirect/phpcodesniffer-composer-installer package needed to be upgraded to 0.7 to support composer 2
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
swissspidy
approved these changes
Oct 26, 2020
swissspidy
reviewed
Oct 26, 2020
| @@ -23,6 +23,6 @@ | |||
| }, | |||
| "scripts": { | |||
| "format": "phpcbf --standard=phpcs.xml.dist --report-summary --report-source", | |||
| "lint": "phpcs --standard=phpcs.xml.dist" | |||
| "lint": "phpcs --standard=phpcs.xml.dist --runtime-set ignore_warnings_on_exit 1" | |||
There was a problem hiding this comment.
Why this change? Seems unrelated?
There was a problem hiding this comment.
There are 7 warnings for VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
Without that change the lint warnings would cause the test to fail
Script phpcs --standard=phpcs.xml.dist handling the lint event returned with error code 1
✖ Command failed with exit code 1
|
I went ahead and merged this to unblock other PRs. Thanks for the fix! We can always follow-up on |
tellthemachines
pushed a commit
that referenced
this pull request
Oct 27, 2020
|
Thanks @noahtallen - a follow up task can be to clear the warnings and then remove the flag. Tracking ticket created: #26490 |
tellthemachines
added a commit
that referenced
this pull request
Oct 27, 2020
* Fix drop zone indicators for non blocks (#25986) * Remove isDraggingBlocks check * Clean up drag and drop data if the user presses escape when dragging * Add comment to ensure avoidance of dragend * Switch to using dragend * Fix archives block render function (#26309) * Code block: preserve indentation on paste (#26347) * Turn off autocomplete for token input. (#26427) * Fix parent post selector: ensure initial value available, search performed, all results shown. (#26397) Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> * [RNMobile] Fix CI issues during `npm ci` (#26455) * Run mobile tests on master * Debug CI * Revert "Debug CI" This reverts commit dec1ebe. * Update react-native-screens ref, pin @react-navigation/native version * Pin @react-navigation/core,router versions * Fix composer test failures due to invalid lock (#26472) * Fix gallery block undo issue (#26377) * Mark change in attributes when gallery mounts as not persistant * Fix typo * Fix package lock changes * Fix some Twenty Twenty One related e2e test failures (#26341) * Account for unknown number of controls in block inspector * Ensure selection is on-screen by using a group block instead of cover, which takes up less space on screen * Fix typewriter test * Use correct name for patterns test * Revert change to .wp-env.json * Fix multi-entity side editor saving test * Remove blank line * insert paragraph instead of tempalte part (#26371) * Fix autosave e2e tests (#26416) * Update how block to render is tracked (#26356) Co-authored-by: Daniel Richards <daniel.richards@automattic.com> Co-authored-by: Riad Benguella <benguella@gmail.com> Co-authored-by: Ella van Durpe <wp@iseulde.com> Co-authored-by: Adam Silverstein <adamsilverstein@earthboundhosting.com> Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com> Co-authored-by: Marcus Kazmierczak <marcus@mkaz.com> Co-authored-by: Addison Stavlo <Stavz01@gmail.com> Co-authored-by: O André <nosolosw@users.noreply.github.com>
noisysocks
pushed a commit
that referenced
this pull request
Oct 29, 2020
noisysocks
added a commit
that referenced
this pull request
Oct 29, 2020
* Refactor BlockMover to use React hooks (#24774) * Add drag handle to block toolbar (#24852) * Add drag handle to block mover component * Switch draggable chip to reflect toolbar layout * Use drag cursor * Hide drag handle on mobile or in top toolbar mode * Adjust handle and structure. * Size the switcher. * Adjust mover. * Update icon for handle. * Update movers buttons. * Fix groups. * Focus for switcher. * Handle focus. * Fix top toolbar. * Popover fix. * Fix spacing issue. * Harmonize spacing. * Try small independen transition for up / down. * Reduce motion. * use dragHandle icon in draggable chip * Make draggable chip use same icon as toolbar * Revert "Make draggable chip use same icon as toolbar" This reverts commit d031006. * Revert offset change and ensure cursor does not overlap chip block info * Update snapshots to reflect chevron icon change Co-authored-by: jasmussen <joen@automattic.com> Co-authored-by: Matías Ventura <mv@matiasventura.com> * Fix issue with single block. (#25107) * Remove animation from mover buttons. (#25728) The animation was intended to better convey direction, and were added as an experiment. It doesn't seem successful, so let's remove it again. * add label in drag and drop button (#25606) * Change toolbar drag remove labels (#25614) * Refactor toolabar drag+remove labels * fix tests * fixes #24845 (#24847) * Fix: Post schedule label showing wrong time if site and user timezones did not match (#26212) * URLInput: Use debounce() instead of throttle() (#26529) Wait until the user finishes typing before sending an AJAX request. This ensures that there isn't an AJAX request sent every 200 ms while the user is typing. * Update browserlist dependency (#24756) * Fix composer test failures due to invalid lock (#26472) * Update package-lock.json * Set dev environment to use WordPress 5.5 Co-authored-by: Chris Alexander <cmalex@gmail.com> Co-authored-by: Daniel Richards <daniel.richards@automattic.com> Co-authored-by: jasmussen <joen@automattic.com> Co-authored-by: Matías Ventura <mv@matiasventura.com> Co-authored-by: Joen A <1204802+jasmussen@users.noreply.github.com> Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> Co-authored-by: Ari Stathopoulos <aristath@gmail.com> Co-authored-by: Jorge Costa <jorge.costa@automattic.com> Co-authored-by: Riad Benguella <benguella@gmail.com> Co-authored-by: Marcus Kazmierczak <marcus@mkaz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
dealerdirect/phpcodesniffer-composer-installerpackage needed to be upgraded to 0.7 to support composer 2.How has this been tested?
Run:
npm run wp-env run composer 'install --no-interaction'and confirm error, you can also see this in recent continuous integration test failures.Apply the change, and run and the error is cleared up. 👍
Types of changes