Refactores the Tooltip component into a functional component #27353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzim
changed the title
draganescu
approved these changes
Dec 4, 2020
There was a problem hiding this comment.
LGTM, tested and works as expected. @grzim check if the tests pas and maybe fix that nitpick I left about that old comment.
| } | ||
| function Tooltip( { children, position, text, shortcut } ) { | ||
| /** | ||
| * Whether a the mouse is currently pressed, used in determining whether |
There was a problem hiding this comment.
"Whether a the mouse" => "Whether the mouse"
There was a problem hiding this comment.
comment fixed,
tooltip unit tests are passing
grzim
requested review from
adamziel,
ajlende,
cameronvoell,
ellatrix,
guarani,
gziolo,
karmatosed,
kevin940726,
mapk,
mkaz,
mkevins,
nerrad,
noisysocks,
ntwb,
spacedmonkey,
talldan,
tellthemachines and
TimothyBJacobs
as code owners
grzim
force-pushed
the
from-classical-to-fn-tootltip
branch
from
04b5d36
to
be513bc
Compare
6 tasks
|
resolved in #27682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regarding #22890 "Refactor all React class components to functional components using hooks" this pull request contains a rewritten tooltip
How has this been tested?
Changes tested visually and with a set of unit tests that were adjusted to work with the functional component.
Screenshots
Types of changes
Refactoring
Checklist: