refactor: tooltip component from classical to functional with hooks #27682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Size Change: -308 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
talldan
added
[Package] Components
talldan
reviewed
Dec 15, 2020
There was a problem hiding this comment.
Nice work here @grzim, it works really well in testing.
I only had a few smaller comments that should be fairly easy to address.
I restarted the tests as there were unrelated failures relating to an issue with axe-core (an accessibility testing framework in our e2e tests).
| * | ||
| * @type {boolean} | ||
| */ | ||
| const [ isMouseDown, setIsMouseDown ] = useState( false ); |
There was a problem hiding this comment.
I wonder a ref could be considered here as the previous implementation didn't use state for this value, instead preferring a property.
There was a problem hiding this comment.
Are you sure ref would be a better option here? My rule of thumb is to avoid mutable values when it is possible
There was a problem hiding this comment.
State will trigger re-renders where a ref wouldn't, but probably not a massive issue in this situation.
talldan
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regarding #22890 "Refactor all React class components to functional components using hooks" this pull request contains a rewritten tooltip
This is a reupload of #27353 . Due to some problems with merging I had to make a new pull request.
How has this been tested?
Changes tested visually and with a set of unit tests that were adjusted to work with the functional component.
Types of changes
Refactor
Checklist: