Font Library: Frontend #53650
Closed
Font Library: Frontend #53650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +90.5 kB (+6%) 🔍 Total Size: 1.6 MB
ℹ️ View Unchanged
|
hellofromtonya
added
[Type] Experimental
16 tasks
|
It appears that there are no testing steps provided for this PR. |
Hi @anton-vlasenko due to the latest backend changes the PR is not running yet. I just imported the changes from the old big PR containing backend, frontend and other utiils. Sorry for not marking this as a draft before. I will be working on this PR and I'll add the testing instructions and ping you when it's ready for review. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/fonts/font-library/google-fonts.json ❔ lib/experimental/fonts/font-library/class-wp-rest-font-library-controller.php |
|
There's consensus to rename the library to a singular form, i.e. from "Fonts Library" to "Font Library". See #52698. References in this PR will also need to be updated. |
|
I'm closing this PR in favor of another PR of a smaller scope that does not include any Google Fonts management: #53884 |
@anton-vlasenko It's ready to test in the other PR: #53884 |
Thanks for the ping, @matiasbenedetto. I'm on it. |
|
Closed, implemented here: #53884 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Implementation of the frontend for Font Library.
Why?
You can see #50927
Testing Instructions
To make the fonts library backend work you need to add this line in your
wp-config.phpfile:define( 'FONT_LIBRARY_ENABLE', true );More info:
Tracking issue: #52698