Font Library: Frontend [Stage 1] #53884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasbenedetto
added
the
[Feature] Typography
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/fonts/font-library/font-library.php ❔ lib/load.php ❔ phpunit/multisite.xml |
|
Size Change: +89.8 kB (+6%) 🔍 Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8736452. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6175605049
|
This was referenced Sep 12, 2023
Test ReportSteps to Test(Mostly following @ironprogrammer 's handy testing guide with different browser. Note: I did not make it through his entire testing suite.)
Environment
Actual results1-2. Fonts List and Management Dialog
3-5. Upload
This was as far as I got in testing before being pulled away. Overall, there is some great stuff here. 👍 |
|
Thanks for the review @colorful-tones !
This is a known issue and it's being worked here: #54320 (comment). It will be fixed soon |
3 tasks
hellofromtonya
approved these changes
Sep 14, 2023
|
Update: I see there is #53653 now. Hi @matiasbenedetto 👋 I have some questions about the organization of the code added by this PR:
I encountered this code when running |
|
Hi @jsnajdr, the 3 files are coming from |
|
I am following @colorful-tones notes above in a similar environment with both Firefox and Chrome browsers, and the Gutenberg nightly active plugin. I ran the test using Playground as well. But I failed to upload fonts. What am I doing wrong? |
|
Update. Because there was no instructions, I was trying to upload the entire downloaded zip folder. But when I uploaded individual TFF file, the file uploads successfully. Thank you. |
@tinjure20 good to know. Thanks for the update! It could be a common mistake, so maybe we should add some kind of visual hint about the need to install font assets and not other types of files. |
IMHO, many users would benefit from a short warning note below the drag-and-drop area. |
|
A couple small things: Item 1 Item 2 "too many" is vague. Will there be a link out for more info? How will someone know if 5 is too many or if 15 is too many? |
Good callout, how many is too many? If you have a great suggestion for phrasing, we can run with it! On the technical side, this issue should ideally mostly disappear in the future, as the Fonts API matures to a point where only the fonts that are actually in use on a particular page of the site, are loaded. I don't believe that is the case yet, but it should be tracked for a future improvement. I'll defer to @matiasbenedetto on details here. So for the time being, it would be good to update the copy. Here's a quick attempt:
I don't actually like the specific size call-out here, to me it puts it way into developer territory, but if we can think of it as temporary until the Fonts API smartly handles it, it might be acceptable? As noted, feel free to suggest an edit! |
|
Hi 👋 This PR was already merged. Please, If the wording needs to be updated, open a new issue with the details of the change. |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Implementation of the frontend for Font Library
Stage 1: Font management and local font uploads.
Why?
The Font Library consists of a font manager for WordPress. The Font Library is available globally, independently of the theme activated, similar to the Media Library. This list of installed fonts and their assets are site-wide available and the users can select the fonts activated (available in the editor) for each theme.
Testing Instructions
Font Library is enabled by default in this PR.
To disable Font Library, add this line
define( 'FONT_LIBRARY_DISABLE', true );to yourwp-config.php.To make the fonts library backend work you need to add this line in your wp-config.php file:
define( 'FONT_LIBRARY_ENABLE', true );🧪 Test in WordPress Playground:
You can try this PR on WordPress Playground following this link
Disclaimer
We are relying on the
lib-fontpackage to read the local font assets metadata. Currently, this PR bundles the source code of that library on the source code. We may find a better alternative for that: #53653This PR depends on:
Follow up tasks:
More info:
Tracking issue: #52698