Patterns: add a new spec for for adding an unsynced pattern #54892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Code Quality
|
Size Change: -22 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
kevin940726
reviewed
Sep 28, 2023
|
Flaky tests detected in 8c3a829. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6335401289
|
Co-authored-by: Kai Hao <kevin830726@gmail.com>
glendaviesnz
commented
Sep 28, 2023
| } ) | ||
| ); | ||
| before.forEach( ( block ) => { | ||
| delete block.clientId; |
There was a problem hiding this comment.
Nice, that is much simpler 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds an e2e spec for adding an unsynced pattern in the post editor.
Why?
To try and guard against future regressions like #54804.
How?
Adds a new spec that goes through the flow of adding an unsynced pattern in the post editor, checking that it is not mistakingly added as synced, and checking that it is then available in the inserter, and gets inserted as a plain block.
Testing Instructions
npm run test:e2e:playwright specs/editor/various/unsynced-pattern.spec.js