Make editor.getBlocks to return only testing-related properties
#54901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Automated Testing
Mamaduka
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As suggested by @ellatrix in a private conversation some time ago, we probably don't need
getBlocksto returnclientIdand other properties for testing purposes.A recent encounter is #54892 (comment).
Why?
This is going to make
editor.getBlocksslightly more helpful in some situations that we can just compare usingtoEqualrather than having to get rid ofclientIdfirst.How?
Recursively transform the blocks before returning. A
fulloption can be passed if the users want to retain the previous behavior.Another idea would be to allow comparing blocks with consideration of the default attributes' values. That would be probably be better suited in a different PR though.
Testing Instructions
CI should pass.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A