Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Add flex-grow rule to overlapping columns block style. #372

Merged
merged 3 commits into from
Oct 9, 2020

Conversation

kjellr
Copy link
Collaborator

@kjellr kjellr commented Oct 8, 2020

Followup from #337. Adds a single flex-grow: 1 rule to fix an issue where the columns did not take up the full width at tablet-size breakpoints (between 600-781px).

Before After
Screen Shot 2020-10-08 at 1 41 26 PM Screen Shot 2020-10-08 at 1 39 33 PM

@kjellr kjellr added the [Type] Bug Something isn't working label Oct 8, 2020
@kjellr kjellr self-assigned this Oct 8, 2020
Copy link
Contributor

@melchoyce melchoyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in Chrome, Firefox, and Safari 👍

Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aristath aristath merged commit e50d8f7 into trunk Oct 9, 2020
@aristath aristath deleted the fix/overlapping-columns-tablet-breakpoints branch October 9, 2020 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants