Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Fix custom column width appearance combined with the Overlap columns block style #653

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

kjellr
Copy link
Collaborator

@kjellr kjellr commented Oct 22, 2020

As noted in #14 (comment), the flex-grow property added in #372 messes with the ability for folks to customize column width. This PR removes that and specifies a justify-content on the parent instead. The result is mostly the same.

The issue with between 600-781px that was fixed in #372 is still mostly solved. The spacing is very slightly different in that scenario (it doesn't go 100% the full width), but it still looks close to what it does in the editor, so I think it's a decent improvement for now.

Test instructions

This PR can be tested by following these steps:

  1. Add a couple columns, set them to the "Overlap" block style.
  2. Modify the width of one of the columns.
  3. Verify that the front end matches the editor.

Screenshots

Before

Editor Front End
gutenberg test_wp-admin_post php_post=2726 action=edit gutenberg test__p=2726 (2)

After

Editor Front End
gutenberg test_wp-admin_post php_post=2726 action=edit gutenberg test__p=2726 (1)

@kjellr kjellr added the [Type] Bug Something isn't working label Oct 22, 2020
@kjellr kjellr self-assigned this Oct 22, 2020
@kjellr kjellr mentioned this pull request Oct 22, 2020
5 tasks
@carolinan carolinan merged commit 677e04d into trunk Oct 23, 2020
@aristath aristath deleted the fix/custom-column-width-spacing-overlap branch October 23, 2020 08:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants