Add wheel build for the aarch64 architecture in Github actions #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mh-northlander
requested changes
Sep 20, 2024
| @@ -56,6 +59,7 @@ jobs: | |||
|
|
|||
| - uses: eiennohito/gha-manylinux-build@master | |||
| with: | |||
| arch: ${{ matrix.arch }} | |||
| script: python/build-wheels-manylinux-pgo.sh | |||
|
|
|||
| - uses: actions/upload-artifact@v4 | |||
There was a problem hiding this comment.
upload-artifact@v4 does not allow uploading multiple times with same name.
Add matrix parameter to name input (it must match artifact-* pattern in l.120).
Also, we merge contents of each artifacts with download-artifact@v4 in upload-to-pypi job.
The names of built files should be changed not to overwrite other architecture's.
| @@ -56,6 +59,7 @@ jobs: | |||
|
|
|||
| - uses: eiennohito/gha-manylinux-build@master | |||
There was a problem hiding this comment.
eiennohito/gha-manylinux-build does not have arch input.
I guess we need a different method to build aarch64 wheel.
There was a problem hiding this comment.
I can update the build definition if somebody makes a PR for it. Or you can clone the repo to your user and use the clone definiton.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in the
Build Linux Python Wheels (+PGO)job of thePython PackagesGithub actions workflow, a newarchmatrix variable to build the wheel on theaarch64architecture.The wheel already builds fine on the
aarch64architecture in local.This PR fixes the #220 issue.
I didn't test this new configuration in the Github workflow because I don't know how to test it.