Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wheel build for the aarch64 architecture in Github actions #272

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add wheel build for the aarch64 architecture in Github actions #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build-python-wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ jobs:
build-linux-wheels:
name: Build Linux Python Wheels (+PGO)
runs-on: ubuntu-latest
strategy:
matrix:
arch: [none, aarch64]
steps:
- uses: actions/checkout@v4

Expand All @@ -56,6 +59,7 @@ jobs:

- uses: eiennohito/gha-manylinux-build@master
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eiennohito/gha-manylinux-build does not have arch input.
I guess we need a different method to build aarch64 wheel.

Copy link
Collaborator

@eiennohito eiennohito Sep 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can update the build definition if somebody makes a PR for it. Or you can clone the repo to your user and use the clone definiton.

with:
arch: ${{ matrix.arch }}
script: python/build-wheels-manylinux-pgo.sh

- uses: actions/upload-artifact@v4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upload-artifact@v4 does not allow uploading multiple times with same name.
Add matrix parameter to name input (it must match artifact-* pattern in l.120).

Also, we merge contents of each artifacts with download-artifact@v4 in upload-to-pypi job.
The names of built files should be changed not to overwrite other architecture's.

Expand Down