Support for FS100 controllers #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Humble only for now.
Humble only for now.
Update use of constants and add conditionals to account for this.
So update relevant constants to account for this.
So gate it.
So introduce a custom implementation for FS100 and call that instead.
Gate it on controller platforms which are known to support it (similar to how we do this in MotoROS1).
Limit use to controller series known to have it and have FS100 just fail the function completely.
`mpFstat(..)` doesn't appear to work reliably, or at least not for files on USB sticks and SRAM drive (not sure about main FS). Use (a custom implementation of) `tell(..)` to determine actual file size and use it to override `stat::st_size`.
Previous conditional was too conservative. Add FS100 to supported controllers.
Otherwise the binary won't load, and this should still be sufficient for the maximum size of the goals we want/need to support.
|
I'll re-open from a branch on this repository to get CI to run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #19.
A draft currently, but first steps towards FS100 support.