Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation of Loofah::HTML5::WhiteList #307

Closed
smap9 opened this issue Oct 1, 2019 · 4 comments
Closed

Deprecation of Loofah::HTML5::WhiteList #307

smap9 opened this issue Oct 1, 2019 · 4 comments

Comments

@smap9
Copy link

smap9 commented Oct 1, 2019

After updating my redmine I got this message redmine/plugins/redmine_ckeditor/init.rb:22: warning: constant Loofah::HTML5::WhiteList is deprecated

It seems to be after updating flavorjones/loofah to https://github.com/flavorjones/loofah/releases/tag/v2.3.0
@joglomedia
Copy link

@smap9 did you have any solutions for this issue?

@tantic
Copy link

tantic commented Dec 20, 2019

I think WhiteList has been replaced with SafeList, so changing
this in init.rb (line 22)

Loofah::HTML5::WhiteList::ALLOWED_PROTOCOLS.replace RedmineCkeditor.allowed_protocols

with

Loofah::HTML5::SafeList::ALLOWED_PROTOCOLS.replace RedmineCkeditor.allowed_protocols

worked for me

@tantic
Copy link

tantic commented Dec 20, 2019 •
edited
Loading

And maybe update rails_html_sanitizer to 1.3.0 with the bundle update command

a-ono added a commit that referenced this issue Feb 6, 2020
@a-ono
refs #307 Fixed deprecation warning
fcbd39b
@a-ono
Copy link
Owner

a-ono commented Feb 6, 2020

Fixed in version 1.2.3.

@a-ono a-ono closed this as completed Feb 6, 2020
@yahoodzilla yahoodzilla mentioned this issue Oct 28, 2021
Open
jayoung-mojito pushed a commit to mojitogames/redmine_ckeditor that referenced this issue Feb 7, 2023
@a-ono @jayoung-mojito
refs a-ono#307 Fixed deprecation warning
3045b3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@a-ono @joglomedia @tantic @smap9